feat: Group API in core and extensions #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomaspoignant
requested review from
beeme1mr,
Kavindu-Dodan,
lukas-reining and
jonathannorris
and removed request for
a team
grimly
reviewed
Jun 7, 2024
beeme1mr
approved these changes
Jun 7, 2024
thomaspoignant
force-pushed
the
configuration-ofrep-extension
branch
from
b348715
to
64fa2a4
Compare
Kavindu-Dodan
approved these changes
Jun 7, 2024
There was a problem hiding this comment.
I have this suggestion [1], otherwise this is a good improvement :)
[1] - https://github.com/open-feature/protocol/pull/23/files#r1631670185
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
* feat!: change minPollingInterval field name to mention millisecond Signed-off-by: Thomas Poignant <[email protected]> * change name to ms Signed-off-by: Thomas Poignant <[email protected]> --------- Signed-off-by: Thomas Poignant <[email protected]>
Co-authored-by: Kavindu Dodanduwa <[email protected]> Signed-off-by: Thomas Poignant <[email protected]> Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
force-pushed
the
configuration-ofrep-extension
branch
from
7654d7f
to
90c99f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
OFREP coreandOFREP extensions.