Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement OpenTelemetry traces hook #11

Merged
merged 4 commits into from
Oct 2, 2023
Merged

feat: implement OpenTelemetry traces hook #11

merged 4 commits into from
Oct 2, 2023

Conversation

federicobond
Copy link
Member

@federicobond federicobond commented Jul 18, 2023 •
edited
Loading

This PR

  • Implements an OpenTelemetry tracing hook according to the semantic conventions for feature flags.

Related Issues

Implements #7

@codecov
Copy link

codecov bot commented Jul 18, 2023 •
edited
Loading

Codecov Report

Merging #11 (4bbd718) into main (9d73fd7) will decrease coverage by 0.92%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   88.11%   87.20%   -0.92%     
==========================================
  Files           7        8       +1     
  Lines         101      125      +24     
==========================================
+ Hits           89      109      +20     
- Misses         12       16       +4
Flag Coverage Δ
unittests 87.20% <83.33%> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
openfeature/contrib/hooks/otel.py 83.33% <83.33%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@federicobond federicobond added the enhancement New feature or request label Jul 18, 2023
@federicobond federicobond marked this pull request as ready for review September 28, 2023 08:52
beeme1mr
beeme1mr reviewed Sep 28, 2023
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed this one. Please @ mention me if I miss a review in the future.

Could you please also add a short readme that describes how to use this hook? The JS doc may be a useful reference.

https://github.com/open-feature/js-sdk-contrib/tree/main/libs/hooks/open-telemetry

openfeature/contrib/hooks/otel.py Outdated Show resolved Hide resolved
@federicobond
Copy link
Member Author

@beeme1mr no worries, it was only recently that I moved it from draft and added you as a reviewer.

@federicobond
Copy link
Member Author

I just added a readme entry for the hook and updated its name following your recommendation.

beeme1mr
beeme1mr approved these changes Oct 2, 2023
View reviewed changes
openfeature/contrib/hooks/README.md Outdated Show resolved Hide resolved
@federicobond federicobond merged commit 0e912ad into open-feature:main Oct 2, 2023
8 of 10 checks passed
@federicobond federicobond deleted the feat/otel-hook branch October 23, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@toddbaert toddbaert Awaiting requested review from toddbaert

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@federicobond @beeme1mr