Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get_path_for implementation #20

Merged
merged 1 commit into from
Sep 29, 2023
Merged

fix: get_path_for implementation #20

merged 1 commit into from
Sep 29, 2023

Conversation

agardnerIT
Copy link
Contributor

This PR

  • Fixes the implementation of get_path_for so it works

Related Issues

Fixes #17

@odubajDT
Copy link

Hey @agardnerIT, thank you for the contribution! Can you please fix the unit tests?

Signed-off-by: Adam Gardner <[email protected]>
Signed-off-by: Federico Bond <[email protected]>
@federicobond
Copy link
Member

Hi @agardnerIT, I rebased and slightly edited your PR. Commit is still attributed to you.

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #20 (9cecb89) into main (5a6d551) will increase coverage by 5.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   83.00%   88.11%   +5.11%     
==========================================
  Files           7        7              
  Lines         100      101       +1     
==========================================
+ Hits           83       89       +6     
+ Misses         17       12       -5     
Flag Coverage Δ
unittests 88.11% <100.00%> (+5.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ure/contrib/providers/flagd/web_api_url_factory.py 89.28% <100.00%> (+15.21%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@federicobond federicobond merged commit 9d73fd7 into open-feature:main Sep 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_path_for is broken
3 participants