Skip to content

Commit

Permalink
Use fetch_*_details instead of value
Browse files Browse the repository at this point in the history 
Signed-off-by: Thomas Poignant <[email protected]>
  • Loading branch information
@thomaspoignant
thomaspoignant committed Aug 5, 2024
1 parent 70714c7 commit 8208886
Show file tree
Hide file tree
Showing 2 changed files with 179 additions and 31 deletions.
16 changes: 15 additions & 1 deletion providers/openfeature-go-feature-flag-provider/lib/openfeature/go-feature-flag/goff_api.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def parse_error_response(response)
key: parsed["key"],
reason: OpenFeature::SDK::Provider::Reason::ERROR,
variant: nil,
error_code: parsed["error_code"],
error_code: error_code_mapper(parsed["error_code"]),
error_details: parsed["error_details"],
metadata: nil
)
Expand Down Expand Up @@ -128,6 +128,20 @@ def reason_mapper(reason_str)
reason_map[reason_str] || OpenFeature::SDK::Provider::Reason::UNKNOWN
end

def error_code_mapper(error_code_str)
error_code_str = error_code_str.upcase
error_code_map = {
"PROVIDER_NOT_READY" => OpenFeature::SDK::Provider::ErrorCode::PROVIDER_NOT_READY,
"FLAG_NOT_FOUND" => OpenFeature::SDK::Provider::ErrorCode::FLAG_NOT_FOUND,
"PARSE_ERROR" => OpenFeature::SDK::Provider::ErrorCode::PARSE_ERROR,
"TYPE_MISMATCH" => OpenFeature::SDK::Provider::ErrorCode::TYPE_MISMATCH,
"TARGETING_KEY_MISSING" => OpenFeature::SDK::Provider::ErrorCode::TARGETING_KEY_MISSING,
"INVALID_CONTEXT" => OpenFeature::SDK::Provider::ErrorCode::INVALID_CONTEXT,
"GENERAL" => OpenFeature::SDK::Provider::ErrorCode::GENERAL
}
error_code_map[error_code_str] || OpenFeature::SDK::Provider::ErrorCode::GENERAL
end

def parse_retry_later_header(response)
retry_after = response["Retry-After"]
return nil if retry_after.nil?
Expand Down
194 changes: 164 additions & 30 deletions ...ders/openfeature-go-feature-flag-provider/spec/openfeature/gofeatureflag/provider_spec.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,21 @@
config.set_provider(goff_provider, domain: test_name)
end
client = OpenFeature::SDK.build_client(domain: test_name)
bool_value = client.fetch_boolean_value(
got = client.fetch_boolean_details(
flag_key: "boolean_flag",
default_value: false,
evaluation_context: OpenFeature::SDK::EvaluationContext.new(targeting_key: "9b9450f8-ab5c-4dcf-872f-feda3f6ccb16")
)
expect(bool_value).to be_truthy
want = OpenFeature::SDK::EvaluationDetails.new(
flag_key: "boolean_flag",
resolution_details: OpenFeature::SDK::Provider::ResolutionDetails.new(
value: true,
reason: OpenFeature::SDK::Provider::Reason::TARGETING_MATCH,
variant: "variantA",
flag_metadata: {"website" => "https://gofeatureflag.org"}
)
)
expect(got).to eql(want)
end

it "should return the default value if flag is not the right type" do
Expand All @@ -71,12 +80,21 @@
config.set_provider(goff_provider, domain: test_name)
end
client = OpenFeature::SDK.build_client(domain: test_name)
bool_value = client.fetch_boolean_value(
got = client.fetch_boolean_details(
flag_key: "boolean_flag",
default_value: false,
evaluation_context: OpenFeature::SDK::EvaluationContext.new(targeting_key: "9b9450f8-ab5c-4dcf-872f-feda3f6ccb16")
)
expect(bool_value).to be_falsey
want = OpenFeature::SDK::EvaluationDetails.new(
flag_key: "boolean_flag",
resolution_details: OpenFeature::SDK::Provider::ResolutionDetails.new(
value: false,
reason: OpenFeature::SDK::Provider::Reason::ERROR,
error_code: OpenFeature::SDK::Provider::ErrorCode::TYPE_MISMATCH,
error_message: "flag type String does not match allowed types [TrueClass, FalseClass]"
)
)
expect(got).to eql(want)
end

it "should return the default value of the flag if error send by the API (http code 403)" do
Expand All @@ -88,12 +106,21 @@
config.set_provider(goff_provider, domain: test_name)
end
client = OpenFeature::SDK.build_client(domain: test_name)
bool_value = client.fetch_boolean_value(
got = client.fetch_boolean_details(
flag_key: "boolean_flag",
default_value: false,
evaluation_context: OpenFeature::SDK::EvaluationContext.new(targeting_key: "9b9450f8-ab5c-4dcf-872f-feda3f6ccb16")
)
expect(bool_value).to be_falsey
want = OpenFeature::SDK::EvaluationDetails.new(
flag_key: "boolean_flag",
resolution_details: OpenFeature::SDK::Provider::ResolutionDetails.new(
value: false,
reason: OpenFeature::SDK::Provider::Reason::ERROR,
error_code: OpenFeature::SDK::Provider::ErrorCode::GENERAL,
error_message: "unauthorized"
)
)
expect(got).to eql(want)
end

it "should return the default value of the flag if error send by the API (http code 400)" do
Expand All @@ -109,12 +136,20 @@
config.set_provider(goff_provider, domain: test_name)
end
client = OpenFeature::SDK.build_client(domain: test_name)
bool_value = client.fetch_boolean_value(
got = client.fetch_boolean_details(
flag_key: "boolean_flag",
default_value: false,
evaluation_context: OpenFeature::SDK::EvaluationContext.new(targeting_key: "9b9450f8-ab5c-4dcf-872f-feda3f6ccb16")
)
expect(bool_value).to be_falsey
want = OpenFeature::SDK::EvaluationDetails.new(
flag_key: "boolean_flag",
resolution_details: OpenFeature::SDK::Provider::ResolutionDetails.new(
value: false,
reason: OpenFeature::SDK::Provider::Reason::ERROR,
error_code: OpenFeature::SDK::Provider::ErrorCode::INVALID_CONTEXT
)
)
expect(got).to eql(want)
end

it "should return default value if no evaluation context" do
Expand All @@ -133,12 +168,21 @@
config.set_provider(goff_provider, domain: test_name)
end
client = OpenFeature::SDK.build_client(domain: test_name)
bool_value = client.fetch_boolean_value(
got = client.fetch_boolean_details(
flag_key: "boolean_flag",
default_value: false,
evaluation_context: nil
)
expect(bool_value).to be_falsey
want = OpenFeature::SDK::EvaluationDetails.new(
flag_key: "boolean_flag",
resolution_details: OpenFeature::SDK::Provider::ResolutionDetails.new(
value: false,
reason: OpenFeature::SDK::Provider::Reason::ERROR,
error_code: OpenFeature::SDK::Provider::ErrorCode::INVALID_CONTEXT,
error_message: "invalid evaluation context provided"
)
)
expect(got).to eql(want)
end

it "should return default value if evaluation context has empty string targetingKey" do
Expand All @@ -157,12 +201,21 @@
config.set_provider(goff_provider, domain: test_name)
end
client = OpenFeature::SDK.build_client(domain: test_name)
bool_value = client.fetch_boolean_value(
got = client.fetch_boolean_details(
flag_key: "boolean_flag",
default_value: false,
evaluation_context: OpenFeature::SDK::EvaluationContext.new(targeting_key: "")
)
expect(bool_value).to be_falsey
want = OpenFeature::SDK::EvaluationDetails.new(
flag_key: "boolean_flag",
resolution_details: OpenFeature::SDK::Provider::ResolutionDetails.new(
value: false,
reason: OpenFeature::SDK::Provider::Reason::ERROR,
error_code: OpenFeature::SDK::Provider::ErrorCode::INVALID_CONTEXT,
error_message: "invalid evaluation context provided"
)
)
expect(got).to eql(want)
end

it "should return default value if evaluation context has nil targetingKey" do
Expand All @@ -181,12 +234,21 @@
config.set_provider(goff_provider, domain: test_name)
end
client = OpenFeature::SDK.build_client(domain: test_name)
bool_value = client.fetch_boolean_value(
got = client.fetch_boolean_details(
flag_key: "boolean_flag",
default_value: false,
evaluation_context: OpenFeature::SDK::EvaluationContext.new(targeting_key: nil)
)
expect(bool_value).to be_falsey
want = OpenFeature::SDK::EvaluationDetails.new(
flag_key: "boolean_flag",
resolution_details: OpenFeature::SDK::Provider::ResolutionDetails.new(
value: false,
reason: OpenFeature::SDK::Provider::Reason::ERROR,
error_code: OpenFeature::SDK::Provider::ErrorCode::INVALID_CONTEXT,
error_message: "invalid evaluation context provided"
)
)
expect(got).to eql(want)
end

it "should return default value if flag_key nil" do
Expand All @@ -205,12 +267,21 @@
config.set_provider(goff_provider, domain: test_name)
end
client = OpenFeature::SDK.build_client(domain: test_name)
bool_value = client.fetch_boolean_value(
got = client.fetch_boolean_details(
flag_key: nil,
default_value: false,
evaluation_context: OpenFeature::SDK::EvaluationContext.new(targeting_key: "1234")
)
expect(bool_value).to be_falsey
want = OpenFeature::SDK::EvaluationDetails.new(
flag_key: nil,
resolution_details: OpenFeature::SDK::Provider::ResolutionDetails.new(
value: false,
reason: OpenFeature::SDK::Provider::Reason::ERROR,
error_code: OpenFeature::SDK::Provider::ErrorCode::GENERAL,
error_message: "invalid flag key provided"
)
)
expect(got).to eql(want)
end

it "should return default value if flag_key empty string" do
Expand All @@ -229,12 +300,21 @@
config.set_provider(goff_provider, domain: test_name)
end
client = OpenFeature::SDK.build_client(domain: test_name)
bool_value = client.fetch_boolean_value(
got = client.fetch_boolean_details(
flag_key: "",
default_value: false,
evaluation_context: OpenFeature::SDK::EvaluationContext.new(targeting_key: "1234")
)
expect(bool_value).to be_falsey
want = OpenFeature::SDK::EvaluationDetails.new(
flag_key: "",
resolution_details: OpenFeature::SDK::Provider::ResolutionDetails.new(
value: false,
reason: OpenFeature::SDK::Provider::Reason::ERROR,
error_code: OpenFeature::SDK::Provider::ErrorCode::GENERAL,
error_message: "invalid flag key provided"
)
)
expect(got).to eql(want)
end
end

Expand All @@ -255,12 +335,21 @@
config.set_provider(goff_provider, domain: test_name)
end
client = OpenFeature::SDK.build_client(domain: test_name)
value = client.fetch_string_value(
got = client.fetch_string_details(
flag_key: "flag_key",
default_value: "default",
evaluation_context: OpenFeature::SDK::EvaluationContext.new(targeting_key: "9b9450f8-ab5c-4dcf-872f-feda3f6ccb16")
)
expect(value).to eq("aValue")
want = OpenFeature::SDK::EvaluationDetails.new(
flag_key: "flag_key",
resolution_details: OpenFeature::SDK::Provider::ResolutionDetails.new(
value: "aValue",
variant: "variantA",
reason: OpenFeature::SDK::Provider::Reason::TARGETING_MATCH,
flag_metadata: {"website" => "https://gofeatureflag.org"},
)
)
expect(got).to eql(want)
end

it "should return the default value if flag is not the right type" do
Expand All @@ -279,12 +368,21 @@
config.set_provider(goff_provider, domain: test_name)
end
client = OpenFeature::SDK.build_client(domain: test_name)
value = client.fetch_string_value(
got = client.fetch_string_details(
flag_key: "flag_key",
default_value: "default",
evaluation_context: OpenFeature::SDK::EvaluationContext.new(targeting_key: "9b9450f8-ab5c-4dcf-872f-feda3f6ccb16")
)
expect(value).to eq("default")
want = OpenFeature::SDK::EvaluationDetails.new(
flag_key: "flag_key",
resolution_details: OpenFeature::SDK::Provider::ResolutionDetails.new(
value: "default",
reason: OpenFeature::SDK::Provider::Reason::ERROR,
error_code: OpenFeature::SDK::Provider::ErrorCode::TYPE_MISMATCH,
error_message: "flag type Integer does not match allowed types [String]"
)
)
expect(got).to eql(want)
end
end

Expand All @@ -305,12 +403,21 @@
config.set_provider(goff_provider, domain: test_name)
end
client = OpenFeature::SDK.build_client(domain: test_name)
value = client.fetch_number_value(
got = client.fetch_number_details(
flag_key: "flag_key",
default_value: 25,
evaluation_context: OpenFeature::SDK::EvaluationContext.new(targeting_key: "9b9450f8-ab5c-4dcf-872f-feda3f6ccb16")
)
expect(value).to eq(15)
want = OpenFeature::SDK::EvaluationDetails.new(
flag_key: "flag_key",
resolution_details: OpenFeature::SDK::Provider::ResolutionDetails.new(
value: 15,
variant: "variantA",
reason: OpenFeature::SDK::Provider::Reason::TARGETING_MATCH,
flag_metadata: {"website" => "https://gofeatureflag.org"}
)
)
expect(got).to eql(want)
end

it "should return the default value if flag is not the right type" do
Expand All @@ -329,12 +436,21 @@
config.set_provider(goff_provider, domain: test_name)
end
client = OpenFeature::SDK.build_client(domain: test_name)
value = client.fetch_number_value(
got = client.fetch_number_details(
flag_key: "flag_key",
default_value: 25,
evaluation_context: OpenFeature::SDK::EvaluationContext.new(targeting_key: "9b9450f8-ab5c-4dcf-872f-feda3f6ccb16")
)
expect(value).to eq(25)
want = OpenFeature::SDK::EvaluationDetails.new(
flag_key: "flag_key",
resolution_details: OpenFeature::SDK::Provider::ResolutionDetails.new(
value: 25,
reason: OpenFeature::SDK::Provider::Reason::ERROR,
error_code: OpenFeature::SDK::Provider::ErrorCode::TYPE_MISMATCH,
error_message: "flag type String does not match allowed types [Integer, Float]"
)
)
expect(got).to eql(want)
end
end

Expand All @@ -355,12 +471,21 @@
config.set_provider(goff_provider, domain: test_name)
end
client = OpenFeature::SDK.build_client(domain: test_name)
value = client.fetch_object_value(
got = client.fetch_object_details(
flag_key: "flag_key",
default_value: {"fail" => true},
evaluation_context: OpenFeature::SDK::EvaluationContext.new(targeting_key: "9b9450f8-ab5c-4dcf-872f-feda3f6ccb16")
)
expect(value).to eq({"test" => "test"})
want = OpenFeature::SDK::EvaluationDetails.new(
flag_key: "flag_key",
resolution_details: OpenFeature::SDK::Provider::ResolutionDetails.new(
value: {"test" => "test"},
variant: "variantA",
reason: OpenFeature::SDK::Provider::Reason::TARGETING_MATCH,
flag_metadata: {"website" => "https://gofeatureflag.org"}
)
)
expect(got).to eql(want)
end

it "should return the default value if flag is not the right type" do
Expand All @@ -379,12 +504,21 @@
config.set_provider(goff_provider, domain: test_name)
end
client = OpenFeature::SDK.build_client(domain: test_name)
value = client.fetch_object_value(
got = client.fetch_object_details(
flag_key: "flag_key",
default_value: {"fail" => true},
evaluation_context: OpenFeature::SDK::EvaluationContext.new(targeting_key: "9b9450f8-ab5c-4dcf-872f-feda3f6ccb16")
)
expect(value).to eq({"fail" => true})
want = OpenFeature::SDK::EvaluationDetails.new(
flag_key: "flag_key",
resolution_details: OpenFeature::SDK::Provider::ResolutionDetails.new(
value: {"fail" => true},
reason: OpenFeature::SDK::Provider::Reason::ERROR,
error_code: OpenFeature::SDK::Provider::ErrorCode::TYPE_MISMATCH,
error_message: "flag type String does not match allowed types [Array, Hash]"
)
)
expect(got).to eql(want)
end
end

Expand Down

0 comments on commit 8208886

Please sign in to comment.