feat: integrate flagd provider with OpenFeature SDK #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Chakroun <[email protected]>
Signed-off-by: Alexandre Chakroun <[email protected]>
maxveldink
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
No qualms with how this is written 🦑
To answer your thoughts in the PR, we do not differentiate between floats and integers on the flag eval interface, but I think we should (added an issue for it).
In the MetaProvider I'm working on, I chose to take a dependency on OpenFeature to access the Metadata, ResolutionDetails and pseudo-enumerations defined there. While it does lock to a particular version of OF, I think having those defined upstream makes more sense than us redefinining them in the contrib providers.
providers/openfeature-flagd-provider/lib/openfeature/flagd/provider/client.rb
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexandre Chakroun <[email protected]>
beeme1mr
pushed a commit
that referenced
this pull request
May 16, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.0](openfeature-flagd-provider-v0.0.1...openfeature-flagd-provider/v0.1.0) (2024-05-16) ### ⚠ BREAKING CHANGES * update flagd name and grpc schema ([#30](#30)) ### ✨ New Features * Add flagd provider ([#2](#2)) ([98b695b](98b695b)) * Add support for unix socket path and secure connection ([#8](#8)) ([88436c7](88436c7)) * Flagd provider uses structs from sdk ([#24](#24)) ([d437e7f](d437e7f)) * integrate flagd provider with OpenFeature SDK ([#18](#18)) ([80d6d02](80d6d02)) * Return default value on error ([#25](#25)) ([f365c6d](f365c6d)) * update flagd name and grpc schema ([#30](#30)) ([ddd438a](ddd438a)) ### 🧹 Chore * Format with standard ([#20](#20)) ([bf25043](bf25043)) * Make things work ([#13](#13)) ([5968037](5968037)) * update link to use new doc domain ([#12](#12)) ([9baff65](9baff65)) * upgrade grpc client ([#16](#16)) ([23ed78a](23ed78a)) ### 🔄 Refactoring * OpenFeature::FlagD::Provider::Configuration ([#14](#14)) ([3686eb5](3686eb5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Notes
MetadataandResolutionDetailsstructs be defined on the Open Feature SDK directly and used by providers?fetch_integer_valueandfetch_float_valueinstead offetch_number_value? I did some hack by testing the type of the default value but I feel it would make more sense for the provider to default to using number instead of integer or float if the distinction is not supported