fix: Fractional evaluation #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustinasrce
force-pushed
the
fix/targeting_key
branch
from
dfae78d
to
51f6a82
Compare
…in errors. Signed-off-by: Augustinas Sueris <[email protected]>
Signed-off-by: Augustinas Sueris <[email protected]>
augustinasrce
force-pushed
the
fix/targeting_key
branch
from
51f6a82
to
b0ebc5e
Compare
augustinasrce
commented
Aug 28, 2024
providers/openfeature-flagd-provider/spec/openfeature/flagd/provider_spec.rb
Show resolved
Hide resolved
augustinasrce
commented
Aug 28, 2024
providers/openfeature-flagd-provider/lib/openfeature/flagd/provider/client.rb
Show resolved
Hide resolved
|
Check resolved comments for more details. |
beeme1mr
requested review from
alxckn,
maxveldink and
josecolella
and removed request for
maxveldink
beeme1mr
approved these changes
Aug 29, 2024
alxckn
approved these changes
Aug 29, 2024
maxveldink
pushed a commit
that referenced
this pull request
Aug 30, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.2](openfeature-flagd-provider/v0.1.1...openfeature-flagd-provider/v0.1.2) (2024-08-29) ### 🐛 Bug Fixes * Fractional evaluation ([#41](#41)) ([5bb34f2](5bb34f2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes issues with fractional evaluation (when targeting_key is provided). It always resulted in error.
Related Issues
Fixes #40
Notes
Follow-up Tasks
How to test