Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix MSRV build #91

Merged
merged 2 commits into from
Sep 25, 2024
Merged

chore: fix MSRV build #91

merged 2 commits into from
Sep 25, 2024

Conversation

gruebel
Copy link
Member

@gruebel gruebel commented Sep 22, 2024

This PR

  • had to increase the MSRC version to 1.71.1, because of mockall and tokio

@prnam
Copy link
Contributor

prnam commented Sep 22, 2024

There is no need for 1.67.1 rustc build, @gruebel and @beeme1mr? 🤔

@gruebel
Copy link
Member Author

gruebel commented Sep 22, 2024

@prnam it always depends, we try to support the lowest possible version, but now 2 dependencies need a higher one, so it seems for me to be a good time to increase the minimum supported version.

@sheepduke
Copy link
Contributor

@prnam it always depends, we try to support the lowest possible version, but now 2 dependencies need a higher one, so it seems for me to be a good time to increase the minimum supported version.

I strongly agree that the versions of the dependencies (compiler version included) needs to be kept up-to-date to prevent the project from decaying.

I do not mind upgrading the compiler version at all...

Good work @gruebel 👍

@sheepduke sheepduke merged commit d82a3ec into open-feature:main Sep 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants