fix glossary tests (#19352)

(cherry picked from commit 94cbadb)
open-metadata · Jan 14, 2025 · 25b0fb3 · 25b0fb3
1 parent 2864e17
commit 25b0fb3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Glossary.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Pages/Glossary.spec.ts
@@ -1216,13 +1216,17 @@ test.describe('Glossary tests', () => {
       const firstGlossaryName = json.data[0].displayName;
 
       await expect(
-        page.getByRole('menuitem', { name: firstGlossaryName })
+        page
+          .getByTestId('glossary-left-panel')
+          .getByRole('menuitem', { name: firstGlossaryName })
       ).toBeVisible();
 
       const lastGlossaryName = json.data[json.data.length - 1].displayName;
 
       await expect(
-        page.getByRole('menuitem', { name: lastGlossaryName })
+        page
+          .getByTestId('glossary-left-panel')
+          .getByRole('menuitem', { name: lastGlossaryName })
       ).toBeVisible();
     } finally {
       for (const glossary of glossaries) {

diff --git a/openmetadata-ui/src/main/resources/ui/playwright/utils/glossary.ts b/openmetadata-ui/src/main/resources/ui/playwright/utils/glossary.ts
@@ -62,11 +62,14 @@ export const selectActiveGlossary = async (
   const isSelected = await menuItem.evaluate((element) => {
     return element.classList.contains('ant-menu-item-selected');
   });
-
   if (!isSelected) {
     const glossaryResponse = page.waitForResponse('/api/v1/glossaryTerms*');
     await menuItem.click();
     await glossaryResponse;
+  } else {
+    await page.waitForSelector('[data-testid="loader"]', {
+      state: 'detached',
+    });
   }
 };