update layouting for ErrorPlaceholder

open-metadata · Jan 22, 2025 · 8f3be30 · 8f3be30
1 parent 5b0ae40
commit 8f3be30
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 33 deletions.
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/Domain/DomainPage.component.tsx b/openmetadata-ui/src/main/resources/ui/src/components/Domain/DomainPage.component.tsx
@@ -184,28 +184,32 @@ const DomainPage = () => {
 
     if (!(viewBasicDomainPermission || viewAllDomainPermission)) {
       return (
-        <ErrorPlaceHolder
-          className="mt-0-important"
-          type={ERROR_PLACEHOLDER_TYPE.PERMISSION}
-        />
+        <div className="d-flex justify-center items-center full-height">
+          <ErrorPlaceHolder
+            className="mt-0-important"
+            type={ERROR_PLACEHOLDER_TYPE.PERMISSION}
+          />
+        </div>
       );
     }
 
     if (isEmpty(rootDomains)) {
       return (
-        <ErrorPlaceHolder
-          buttonId="add-domain"
-          className="mt-0-important"
-          heading={t('label.domain')}
-          permission={createDomainPermission}
-          type={
-            createDomainPermission
-              ? ERROR_PLACEHOLDER_TYPE.CREATE
-              : ERROR_PLACEHOLDER_TYPE.CUSTOM
-          }
-          onClick={handleAddDomainClick}>
-          {t('message.domains-not-configured')}
-        </ErrorPlaceHolder>
+        <div className="d-flex justify-center items-center full-height">
+          <ErrorPlaceHolder
+            buttonId="add-domain"
+            className="mt-0-important"
+            heading={t('label.domain')}
+            permission={createDomainPermission}
+            type={
+              createDomainPermission
+                ? ERROR_PLACEHOLDER_TYPE.CREATE
+                : ERROR_PLACEHOLDER_TYPE.CUSTOM
+            }
+            onClick={handleAddDomainClick}>
+            {t('message.domains-not-configured')}
+          </ErrorPlaceHolder>
+        </div>
       );
     }
 

diff --git a/...adata-ui/src/main/resources/ui/src/pages/Glossary/GlossaryPage/GlossaryPage.component.tsx b/...adata-ui/src/main/resources/ui/src/pages/Glossary/GlossaryPage/GlossaryPage.component.tsx
@@ -422,24 +422,30 @@ const GlossaryPage = () => {
     }
 
     if (!(viewBasicGlossaryPermission || viewAllGlossaryPermission)) {
-      return <ErrorPlaceHolder type={ERROR_PLACEHOLDER_TYPE.PERMISSION} />;
+      return (
+        <div className="d-flex justify-center items-center">
+          <ErrorPlaceHolder type={ERROR_PLACEHOLDER_TYPE.PERMISSION} />
+        </div>
+      );
     }
 
     if (glossaries.length === 0 && !isLoading) {
       return (
-        <ErrorPlaceHolder
-          buttonId="add-glossary"
-          className="mt-0-important"
-          doc={GLOSSARIES_DOCS}
-          heading={t('label.glossary')}
-          permission={createGlossaryPermission}
-          type={
-            createGlossaryPermission
-              ? ERROR_PLACEHOLDER_TYPE.CREATE
-              : ERROR_PLACEHOLDER_TYPE.NO_DATA
-          }
-          onClick={handleAddGlossaryClick}
-        />
+        <div className="d-flex justify-center items-center full-height">
+          <ErrorPlaceHolder
+            buttonId="add-glossary"
+            className="mt-0-important"
+            doc={GLOSSARIES_DOCS}
+            heading={t('label.glossary')}
+            permission={createGlossaryPermission}
+            type={
+              createGlossaryPermission
+                ? ERROR_PLACEHOLDER_TYPE.CREATE
+                : ERROR_PLACEHOLDER_TYPE.NO_DATA
+            }
+            onClick={handleAddGlossaryClick}
+          />
+        </div>
       );
     }
 

diff --git a/openmetadata-ui/src/main/resources/ui/src/pages/Persona/PersonaListPage/PersonaPage.tsx b/openmetadata-ui/src/main/resources/ui/src/pages/Persona/PersonaListPage/PersonaPage.tsx
@@ -123,7 +123,7 @@ export const PersonaPage = () => {
   const renderContent = () => {
     if (isEmpty(persona) && !isLoading) {
       return (
-        <>
+        <div className="d-flex justify-center items-center full-height">
           {errorPlaceHolder}
           {Boolean(addEditPersona) && (
             <AddEditPersonaForm
@@ -132,7 +132,7 @@ export const PersonaPage = () => {
               onSave={handlePersonaAddEditSave}
             />
           )}
-        </>
+        </div>
       );
     }