Skip to content

Commit

Permalink
filter empty columns, better msg (#18932)
Browse files Browse the repository at this point in the history
  • Loading branch information
harshsoni2024 authored Dec 5, 2024
1 parent 00e5d29 commit c941569
Showing 1 changed file with 10 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -383,9 +383,12 @@ def _get_column_lineage( # pylint: disable=arguments-differ
column=column.id,
)
for to_column in to_columns:
column_lineage.append(
ColumnLineage(fromColumns=[from_column], toColumn=to_column)
)
if from_column and to_column:
column_lineage.append(
ColumnLineage(
fromColumns=[from_column], toColumn=to_column
)
)
return column_lineage
except Exception as exc:
logger.debug(f"Error to get column lineage: {exc}")
Expand Down Expand Up @@ -452,6 +455,7 @@ def _get_table_datamodel_lineage(
column.id
for field in upstream_data_model.fields
for column in field.upstreamColumns
if column is not None
}
for table in datamodel.upstreamTables or []:
om_tables = self._get_database_tables(db_service_entity, table)
Expand Down Expand Up @@ -889,6 +893,9 @@ def get_project_name(self, dashboard_details: Any) -> Optional[str]:
try:
return dashboard_details.project.name
except Exception as exc:
logger.info(
f"Cannot parse project name for dashboard:{dashboard_details.id} from Tableau server"
)
logger.debug(traceback.format_exc())
logger.warning(
f"Error fetching project name for {dashboard_details.id}: {exc}"
Expand Down

0 comments on commit c941569

Please sign in to comment.