MINOR: Update Glossary Approval Workflow (#19787)

* Update Glossary Approval Workflow * Update Default Workflows * Add small Fix to PeriodicBatchEntity variables
open-metadata · Feb 14, 2025 · fa2d9eb · fa2d9eb
1 parent 165af4a
commit fa2d9eb
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 4 deletions.
diff --git a/...enmetadata/service/governance/workflows/elements/triggers/PeriodicBatchEntityTrigger.java b/...enmetadata/service/governance/workflows/elements/triggers/PeriodicBatchEntityTrigger.java
@@ -121,12 +121,12 @@ private CallActivity getWorkflowTriggerCallActivity(
             .build();
 
     IOParameter inputParameter = new IOParameter();
-    inputParameter.setSource(getNamespacedVariableName(GLOBAL_NAMESPACE, RELATED_ENTITY_VARIABLE));
+    inputParameter.setSource(RELATED_ENTITY_VARIABLE);
     inputParameter.setTarget(getNamespacedVariableName(GLOBAL_NAMESPACE, RELATED_ENTITY_VARIABLE));
 
     IOParameter outputParameter = new IOParameter();
     outputParameter.setSource(getNamespacedVariableName(GLOBAL_NAMESPACE, EXCEPTION_VARIABLE));
-    outputParameter.setTarget(getNamespacedVariableName(GLOBAL_NAMESPACE, EXCEPTION_VARIABLE));
+    outputParameter.setTarget(EXCEPTION_VARIABLE);
 
     workflowTrigger.setInParameters(List.of(inputParameter));
     workflowTrigger.setOutParameters(List.of(outputParameter));

diff --git a/...a-service/src/main/resources/json/data/governance/workflows/GlossaryApprovalWorkflow.json b/...a-service/src/main/resources/json/data/governance/workflows/GlossaryApprovalWorkflow.json
@@ -24,6 +24,12 @@
       "name": "ApprovedEnd",
       "displayName": "Glossary Term Status: Approved"
     },
+    {
+      "type": "endEvent",
+      "subType": "endEvent",
+      "name": "ApprovedEndAfterApproval",
+      "displayName": "Glossary Term Status: Approved"
+    },
     {
       "type": "endEvent",
       "subType": "endEvent",
@@ -101,7 +107,7 @@
     {
       "type": "automatedTask",
       "subType": "setGlossaryTermStatusTask",
-      "name": "SetGlossaryTermStatusToApproved",
+      "name": "SetGlossaryTermStatusToApprovedAfterApproval",
       "displayName": "Set Status to 'Approved'",
       "config": {
         "glossaryTermStatus": "Approved"
@@ -111,6 +117,18 @@
         "updatedBy": "ApproveGlossaryTerm"
       }
     },
+    {
+      "type": "automatedTask",
+      "subType": "setGlossaryTermStatusTask",
+      "name": "SetGlossaryTermStatusToApproved",
+      "displayName": "Set Status to 'Approved'",
+      "config": {
+        "glossaryTermStatus": "Approved"
+      },
+      "inputNamespaceMap": {
+        "relatedEntity": "global"
+      }
+    },
     {
       "type": "automatedTask",
       "subType": "setGlossaryTermStatusTask",
@@ -160,14 +178,18 @@
     },
     {
       "from": "ApproveGlossaryTerm",
-      "to": "SetGlossaryTermStatusToApproved",
+      "to": "SetGlossaryTermStatusToApprovedAfterApproval",
       "condition": "true"
     },
     {
       "from": "ApproveGlossaryTerm",
       "to": "SetGlossaryTermStatusToRejected",
       "condition": "false"
     },
+    {
+      "from": "SetGlossaryTermStatusToApprovedAfterApproval",
+      "to": "ApprovedEndAfterApproval"
+    },
     {
       "from": "SetGlossaryTermStatusToApproved",
       "to": "ApprovedEnd"