fix the richTextEditor output in case on no data save

open-metadata · Jan 22, 2025 · ff1be5c · ff1be5c
1 parent 51bdaac
commit ff1be5c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/...in/resources/ui/src/components/Modals/ModalWithMarkdownEditor/ModalWithMarkdownEditor.tsx b/...in/resources/ui/src/components/Modals/ModalWithMarkdownEditor/ModalWithMarkdownEditor.tsx
@@ -41,8 +41,7 @@ export const ModalWithMarkdownEditor: FunctionComponent<ModalWithMarkdownEditorP
       if (markdownRef.current) {
         setIsLoading(true);
         try {
-          const content =
-            markdownRef.current?.getEditorContent?.()?.trim() ?? '';
+          const content = markdownRef.current?.getEditorContent?.()?.trim();
           await onSave?.(content);
         } catch (error) {
           showErrorToast(error as AxiosError);

diff --git a/...ui/src/main/resources/ui/src/components/common/RichTextEditor/RichTextEditor.interface.ts b/...ui/src/main/resources/ui/src/components/common/RichTextEditor/RichTextEditor.interface.ts
@@ -40,5 +40,5 @@ export interface RichTextEditorProp extends HTMLAttributes<HTMLDivElement> {
 }
 
 export interface EditorContentRef {
-  getEditorContent: () => string;
+  getEditorContent: () => string | undefined;
 }
diff --git a/...metadata-ui/src/main/resources/ui/src/components/common/RichTextEditor/RichTextEditor.tsx b/...metadata-ui/src/main/resources/ui/src/components/common/RichTextEditor/RichTextEditor.tsx
@@ -47,7 +47,7 @@ const RichTextEditor = forwardRef<EditorContentRef, RichTextEditorProp>(
         const htmlContent = editorRef.current?.editor?.getHTML() ?? '';
         const backendFormat = formatContent(htmlContent, 'server');
 
-        return backendFormat;
+        return backendFormat === '<p></p>' ? undefined : backendFormat;
       },
     }));