-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Docker Host Retry #19127
Merged
ayush-shah
merged 15 commits into
open-metadata:main
from
keshavmohta09:feature/dockerhost-retry
Jan 14, 2025
Merged
Feature: Docker Host Retry #19127
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6acb30d
Feature: retry with docker host if error to connect with localhost
keshavmohta09 a793db7
Merge branch 'main' of https://github.com/open-metadata/OpenMetadata …
keshavmohta09 5b474ae
fix: config argument in retry_with_docker_host decorator
keshavmohta09 f999d3c
fix: host_port_type and host_port_str use in runner.py and retry_with…
keshavmohta09 faa38d1
Merge branch 'main' of https://github.com/open-metadata/OpenMetadata …
keshavmohta09 f046159
refactor: code reformatted
keshavmohta09 22eae81
fix: call self.test_connection in set_steps to update host value befo…
keshavmohta09 986cb1a
Merge branch 'main' of https://github.com/open-metadata/OpenMetadata …
keshavmohta09 d7e3f8d
fix: call test_connection in classification test connection
keshavmohta09 d8858aa
Merge branch 'main' of https://github.com/open-metadata/OpenMetadata …
keshavmohta09 7ed5b9f
fix: added mock test and get connection in tests
keshavmohta09 ed8e31c
Merge branch 'main' of https://github.com/open-metadata/OpenMetadata …
keshavmohta09 b116659
fix: add get_engine check for test_connection
keshavmohta09 b548b9b
Merge branch 'main' of https://github.com/open-metadata/OpenMetadata …
keshavmohta09 7093766
Merge branch 'main' into feature/dockerhost-retry
keshavmohta09 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this mean we run the test connection twice in case of localhost and when no exception is thrown?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we need to do this to show the result of test_connection on the frontend