-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: reverted deprecated fields on testSuite #19284
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added deprecated fields with a notice. This is to ensure migrations that use them do not break.
github-actions
bot
added
Ingestion
safe to test
Add this label to run secure Github workflows on PRs
labels
Jan 8, 2025
mohityadav766
approved these changes
Jan 8, 2025
Quality Gate passed for 'open-metadata-ingestion'Issues Measures |
harshach
approved these changes
Jan 8, 2025
aniketkatkar97
approved these changes
Jan 8, 2025
tutte
approved these changes
Jan 8, 2025
Quality Gate passed for 'open-metadata-ui'Issues Measures |
Changes have been cherry-picked to the 1.6.2 branch. |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
Added deprecated fields with a notice. This is to ensure migrations that use them do not break. (cherry picked from commit 7d05902)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Ingestion
safe to test
Add this label to run secure Github workflows on PRs
To release
Will cherry-pick this PR into the release branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Following #19221, migrations fail because
MigrationUtils
rely on objects which use the old schema that contains deprecated fields.Example Failure
Proposed Solution
Keep the deprecated along with a useful description regarding the field that replaces it as well as adding the
@Deprecated
annotation for the field in the created java object. The only context where these deprecated fields should be used is in migrations prior to the version where it was deprecated.Example deprecated field
Future work
These fields will might be included in some contexts where the json documents are consumed fully (API responses. elasticsearch, etc). Need to make sure they are cleaned up by default in these places.
Describe your changes:
Fixes
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>