Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: fix the glossary description column width on term page #19332

Merged
merged 3 commits into from
Jan 15, 2025
Merged

MINOR: fix the glossary description column width on term page #19332

merged 3 commits into from
Jan 15, 2025

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Jan 13, 2025 •
edited
Loading

Describe your changes:

Fixes

  • I worked on fixing the glossary description column width on Glossary Term page

Issue :
image

Resolved :

image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Jan 13, 2025
@Ashish8689 Ashish8689 self-assigned this Jan 13, 2025
@Ashish8689 Ashish8689 requested a review from a team as a code owner January 13, 2025 10:11
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jan 13, 2025
chirag-madlani
chirag-madlani previously approved these changes Jan 13, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.58% (40791/63166) 40.81% (16370/40116) 43.96% (4950/11260)

@Ashish8689 Ashish8689 added the To release Will cherry-pick this PR into the release branch label Jan 14, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Ashish8689 Ashish8689 merged commit b85883b into main Jan 15, 2025
25 of 30 checks passed
@Ashish8689 Ashish8689 deleted the glossary-description-table-column branch January 15, 2025 06:58
@github-actions GitHub Actions
Copy link
Contributor

Changes have been cherry-picked to the 1.6.3 branch.

github-actions bot pushed a commit that referenced this pull request Jan 15, 2025
@Ashish8689
MINOR: fix the glossary description column width on term page (#19332)
4b80b4a 
* fix the glossary description column width on term page

* decrease the width so for smaller screen, other column should not overflow

(cherry picked from commit b85883b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ashish8689 @chirag-madlani