Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(ci) downgrade ubuntu version on playwright jobs #19339

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Fix(ci) downgrade ubuntu version on playwright jobs #19339

merged 2 commits into from
Jan 13, 2025

Conversation

pellejador
Copy link
Contributor

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

tutte
tutte approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@tutte tutte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tutte tutte added the To release Will cherry-pick this PR into the release branch label Jan 13, 2025
@tutte tutte merged commit 21dd3e4 into main Jan 13, 2025
14 of 20 checks passed
@tutte tutte deleted the fix/downgrade-ubuntu-version-on-playwright-jobs branch January 13, 2025 15:55
@github-actions GitHub Actions
Copy link
Contributor

Changes have been cherry-picked to the 1.6.3 branch.

github-actions bot pushed a commit that referenced this pull request Jan 13, 2025
@pellejador
Fix(ci) downgrade ubuntu version on playwright jobs (#19339)
4b2ff1c 
* Fix: downgrading ubuntu version to 22.04 on playwright jobs

* Fix: indentation issue in playwright skip jobs

(cherry picked from commit 21dd3e4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tutte tutte tutte approved these changes

@akash-jain-10 akash-jain-10 Awaiting requested review from akash-jain-10 akash-jain-10 is a code owner

@harshach harshach Awaiting requested review from harshach harshach is a code owner

Assignees
No one assigned
Labels
To release Will cherry-pick this PR into the release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pellejador @tutte