Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dataProduct : get inherited fields from corresponding Domain #19343

Merged
merged 3 commits into from
Jan 14, 2025
Merged

dataProduct : get inherited fields from corresponding Domain #19343

merged 3 commits into from
Jan 14, 2025

Conversation

sonika-shah
Copy link
Contributor

@sonika-shah sonika-shah commented Jan 14, 2025 •
edited
Loading

Describe your changes:

Fixes #19333

  • owners and experts should be inherited from the associated domain if they are not explicitly set in the DataProduct

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sonika-shah sonika-shah added backend safe to test Add this label to run secure Github workflows on PRs labels Jan 14, 2025
@sonika-shah sonika-shah requested a review from a team as a code owner January 14, 2025 06:57
TeddyCr
TeddyCr previously approved these changes Jan 14, 2025
View reviewed changes
@karanh37 karanh37 requested a review from a team as a code owner January 14, 2025 10:32
@karanh37 karanh37 added the To release Will cherry-pick this PR into the release branch label Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.58% (40791/63166) 40.81% (16369/40114) 43.96% (4950/11260)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonika-shah sonika-shah merged commit 788dfc3 into main Jan 14, 2025
26 of 27 checks passed
@sonika-shah sonika-shah deleted the fix-19333 branch January 14, 2025 16:46
@github-actions GitHub Actions
Copy link
Contributor

Changes have been cherry-picked to the 1.6.3 branch.

github-actions bot pushed a commit that referenced this pull request Jan 14, 2025
@sonika-shah
dataProduct : get inherited fields from corresponding Domain (#19343)
12a9da0 
* dataProduct : get inherited fields from corresponding Domain

* add tests

---------

Co-authored-by: karanh37 <[email protected]>
(cherry picked from commit 788dfc3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@harshach harshach harshach approved these changes

@TeddyCr TeddyCr TeddyCr left review comments

Assignees
No one assigned
Labels
backend safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inherited Ownership for Data Products
5 participants
@sonika-shah @harshach @TeddyCr @ShaileshParmar11 @karanh37