Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: added loading state, and error notification in testSuite. #19350

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Minor: added loading state, and error notification in testSuite. #19350

merged 2 commits into from
Jan 14, 2025

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Jan 14, 2025 •
edited
Loading

Describe your changes:

  • Added loading effect while removing test case from test suite
  • Added loading effect while adding test case in to test suite
  • Added error notification while creating testSuite
Screen.Recording.2025-01-14.at.4.30.31.PM.mov
Screen.Recording.2025-01-14.at.4.47.43.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@ShaileshParmar11 ShaileshParmar11 requested a review from a team as a code owner January 14, 2025 09:57
@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 14, 2025 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.59% (40804/63172) 40.87% (16394/40114) 44% (4954/11260)

@ShaileshParmar11 ShaileshParmar11 added the To release Will cherry-pick this PR into the release branch label Jan 14, 2025
@ShaileshParmar11 ShaileshParmar11 self-assigned this Jan 14, 2025
aniketkatkar97
aniketkatkar97 reviewed Jan 14, 2025
View reviewed changes
Copy link
Member

@aniketkatkar97 aniketkatkar97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add tests around this?

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ShaileshParmar11 ShaileshParmar11 merged commit 05f68ec into main Jan 14, 2025
16 of 17 checks passed
@ShaileshParmar11 ShaileshParmar11 deleted the dq-ui-ux-improvement branch January 14, 2025 14:51
@github-actions GitHub Actions
Copy link
Contributor

Changes have been cherry-picked to the 1.6.3 branch.

github-actions bot pushed a commit that referenced this pull request Jan 14, 2025
@ShaileshParmar11
Minor: added loading state, and error notification in testSuite. (#19350
bde5b27 
)

* Minor: added loading state, and error notification in testSuite.

* added the unit test

(cherry picked from commit 05f68ec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniketkatkar97 aniketkatkar97 aniketkatkar97 approved these changes

Assignees

@ShaileshParmar11 ShaileshParmar11

Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaileshParmar11 @aniketkatkar97