Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: fix the favicon not being updated #19357

Merged
merged 2 commits into from
Jan 14, 2025
Merged

MINOR: fix the favicon not being updated #19357

merged 2 commits into from
Jan 14, 2025

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

Fixes #19336

  • I worked on fixing the favicon not being updated
image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added UI UI specific issues To release Will cherry-pick this PR into the release branch labels Jan 14, 2025
@Ashish8689 Ashish8689 self-assigned this Jan 14, 2025
@Ashish8689 Ashish8689 requested a review from a team as a code owner January 14, 2025 13:17
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jan 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.58% (40791/63166) 40.81% (16369/40114) 43.96% (4950/11260)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Ashish8689 Ashish8689 merged commit a28c30e into main Jan 14, 2025
28 of 29 checks passed
@Ashish8689 Ashish8689 deleted the favicon-fix branch January 14, 2025 15:06
@github-actions GitHub Actions
Copy link
Contributor

Changes have been cherry-picked to the 1.6.3 branch.

github-actions bot pushed a commit that referenced this pull request Jan 14, 2025
@Ashish8689
MINOR: fix the favicon not being updated (#19357)
2864e17 
* fix the favicon not being updated

* minor condition check added

(cherry picked from commit a28c30e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

favicon not updating in the browser tab
2 participants
@Ashish8689 @ShaileshParmar11