Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #18834: Introduce new setting OpenMetadataBaseUrlConfiguration to set the server endpoint #19366

Merged
merged 20 commits into from
Jan 27, 2025
Merged

Fix #18834: Introduce new setting OpenMetadataBaseUrlConfiguration to set the server endpoint #19366

merged 20 commits into from
Jan 27, 2025

Conversation

Siddhanttimeline
Copy link
Contributor

@Siddhanttimeline Siddhanttimeline commented Jan 15, 2025 •
edited by karanh37
Loading

Describe your changes:

Fixes #18834

  1. Removed OM Base URL configuration from smtpSettings.
  2. Introduced a new OpenMetadataBaseUrlConfiguration to set the server endpoint.
Screen.Recording.2025-01-24.at.1.49.42.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Siddhanttimeline
Refactor: Introduce openMetadataBaseUrlConfiguration to set up the se…
33f1a8f 
…rver endpoint and remove OpenMetadataUrl from smtpSettings.json
@Siddhanttimeline Siddhanttimeline added backend safe to test Add this label to run secure Github workflows on PRs labels Jan 15, 2025
@Siddhanttimeline Siddhanttimeline self-assigned this Jan 15, 2025
@Siddhanttimeline Siddhanttimeline requested review from a team as code owners January 15, 2025 07:30
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.59% (40952/63403) 40.67% (16360/40226) 44.06% (4974/11289)

@mohityadav766
Copy link
Contributor

Missing migrations @Siddhanttimeline for email settings in openmetadata_settings table

@mohityadav766
Copy link
Contributor

@Siddhanttimeline also you need to update openmetadata_test.yaml for the same

mohityadav766
mohityadav766 requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@mohityadav766 mohityadav766 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check comments

@Siddhanttimeline Siddhanttimeline added the To release Will cherry-pick this PR into the release branch label Jan 16, 2025
@Siddhanttimeline Siddhanttimeline changed the title [WIP] Fix #18834: Introduce new setting OpenMetadataBaseUrlConfiguration to set the server endpoint Fix #18834: Introduce new setting OpenMetadataBaseUrlConfiguration to set the server endpoint Jan 24, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
8.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mohityadav766 mohityadav766 merged commit 4736886 into main Jan 27, 2025
26 of 28 checks passed
@mohityadav766 mohityadav766 deleted the fix-18834 branch January 27, 2025 04:50
@github-actions GitHub Actions
Copy link
Contributor

Failed to cherry-pick changes to the 1.6.3 branch.
Please cherry-pick the changes manually.
You can find more details here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohityadav766 mohityadav766 mohityadav766 approved these changes

@harshach harshach Awaiting requested review from harshach

Assignees

@Siddhanttimeline Siddhanttimeline

Labels
backend safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slack Entity URLs Not Working If OpenMetadata URL Is Not Set in SMTP UI
4 participants
@Siddhanttimeline @mohityadav766 @harshach @karanh37