Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the api should not called after time out in Test connection #19376

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix the api should not called after time out in Test connection #19376

wants to merge 3 commits into from
+15 −7

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Jan 15, 2025 •
edited
Loading

Describe your changes:

Fixes

  • fix the API calls that were being made even after the timeout of the Test Connection.
  • Issue arrived due to the trying to use variable reference being passed to the function and assigning the interval id there. Which doesn't work like it.

Issue :

Screen.Recording.2025-01-15.at.6.01.22.PM.mov

Resolved :

Screen.Recording.2025-01-15.at.5.58.59.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added UI UI specific issues To release Will cherry-pick this PR into the release branch labels Jan 15, 2025
@Ashish8689 Ashish8689 self-assigned this Jan 15, 2025
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jan 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 15, 2025 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.59% (40805/63173) 40.87% (16395/40115) 44% (4954/11260)

@Ashish8689 Ashish8689 marked this pull request as ready for review January 15, 2025 12:49
@Ashish8689 Ashish8689 requested a review from a team as a code owner January 15, 2025 12:49
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ashish8689 @ShaileshParmar11