Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: fix(governance-workflows): defined interface in workflow schema #19384

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

MINOR: fix(governance-workflows): defined interface in workflow schema #19384

wants to merge 1 commit into from
+22 −18

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Jan 15, 2025

  • defined types for workflow nodes
  • fixed updateEdge method in WorkflowDefinitionRepository

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sushi30
fix(governance-workflows): defined interface in workflow schema
e9771bd 
- defined types for workflow nodes
- fixed updateEdge method in WorkflowDefinitionRepository
@sushi30 sushi30 requested review from a team as code owners January 15, 2025 14:12
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Jan 15, 2025
@sushi30 sushi30 changed the title MInOR: fix(governance-workflows): defined interface in workflow schema MINOR: fix(governance-workflows): defined interface in workflow schema Jan 15, 2025
@sushi30 sushi30 requested a review from IceS2 January 15, 2025 14:14
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.59% (40804/63172) 40.87% (16395/40115) 44% (4954/11260)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sushi30 sushi30 marked this pull request as draft January 15, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IceS2 IceS2 Awaiting requested review from IceS2

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sushi30