Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#19474: fix the async export csv not happening in lineage #19397

Merged
merged 7 commits into from
Jan 22, 2025
Merged

#19474: fix the async export csv not happening in lineage #19397

merged 7 commits into from
Jan 22, 2025

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Jan 16, 2025 •
edited
Loading

Describe your changes:

  • Fix the async Export issue download, when the network call is slow.
    • Bug: While exporting before resolving the API call for export ID, web-socket return us the CSV Data, and due to
      having the export condition based on RestAPI Job ID, we were not able to export that.

Issue : #19474

Screen.Recording.2025-01-22.at.11.29.15.AM.mov

Resolved :

Screen.Recording.2025-01-22.at.11.44.42.AM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added UI UI specific issues To release Will cherry-pick this PR into the release branch labels Jan 16, 2025
@Ashish8689 Ashish8689 self-assigned this Jan 16, 2025
@Ashish8689 Ashish8689 requested a review from a team as a code owner January 16, 2025 06:59
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jan 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.65% (40875/63221) 40.89% (16420/40153) 44.11% (4969/11266)

@Ashish8689 Ashish8689 changed the title fix lineage playwright flaky test fix the async export csv not happening Jan 22, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Ashish8689 Ashish8689 changed the title fix the async export csv not happening #19474: fix the async export csv not happening in lineage Jan 22, 2025
@Ashish8689 Ashish8689 merged commit 68c3246 into main Jan 22, 2025
16 of 17 checks passed
@Ashish8689 Ashish8689 deleted the lineage-playwright-fix branch January 22, 2025 07:49
@github-actions GitHub Actions
Copy link
Contributor

Changes have been cherry-picked to the 1.6.3 branch.

github-actions bot pushed a commit that referenced this pull request Jan 22, 2025
@Ashish8689
#19474: fix the async export csv not happening in lineage (#19397)
0bc5164 
* fix lineage playwrigt flaky test

* increase the timer

* fix the async export issue

* remove the timer

* minor revert

(cherry picked from commit 68c3246)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karanh37 karanh37 karanh37 approved these changes

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ashish8689 @karanh37