-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX #19386 & #19388: Fixing Data Insights index mapping #19423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically if we want to add new fields/metrics (or support for a new entity) we'll need to add those to this file, is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to support a new entity actually we have a list on the Java Application itself (It'd be a good idea to remove it and basically support based on the list)
But yes, in order to add any new fields, we'd need to add it there. That way we'd control the amount of data indexed and also we're fetching the mapping that we define in our not-data-insights indexes to reduce the amount of dynamic mapping
@@ -513,6 +517,104 @@ private int executeSearchReindexApp( | |||
return result; | |||
} | |||
|
|||
@Command( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should allow the backfill configuration here to be supplied if needed ,
else only way would be to use UI to set it and then run here if it needs to be run with some different config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already there:
@Option(
names = {"--start-date"},
description = "Start Date to backfill from.")
String startDate,
@Option(
names = {"--end-date"},
description = "End Date to backfill to.")
String endDate) {
Quality Gate passed for 'open-metadata-ingestion'Issues Measures |
Changes have been cherry-picked to the 1.6.3 branch. |
This PR aims to solve three things:
Fix #19386
Fix #19388
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>