fix the richTextEditor output in case on no data save #19476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
safe to test
Jest test CoverageUI tests summary
|
|
karanh37
approved these changes
Jan 22, 2025
Ashish8689
added a commit
that referenced
this pull request
Jan 22, 2025
* fix the richTextEditor output in case on no data save * revert the undefined to empty string as we previously had (cherry picked from commit 06759c5)
| @@ -47,7 +47,7 @@ const RichTextEditor = forwardRef<EditorContentRef, RichTextEditorProp>( | |||
| const htmlContent = editorRef.current?.editor?.getHTML() ?? ''; | |||
| const backendFormat = formatContent(htmlContent, 'server'); | |||
|
|
|||
| return backendFormat; | |||
| return backendFormat === '<p></p>' ? '' : backendFormat; | |||
There was a problem hiding this comment.
I feel we can control this inside formatContent itself instead having condition on component end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes
<p></p>tag in the editor response.Type of change:
Checklist:
Fixes <issue-number>: <short explanation>