Fix #17723: Generate Incremental Change Events even when consolidation of events applied #19550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n of events applied
github-actions
bot
added
backend
safe to test
…n of events applied
sushi30
reviewed
Jan 28, 2025
openmetadata-service/src/main/java/org/openmetadata/service/jdbi3/EntityRepository.java
Show resolved
Hide resolved
sonika-shah
reviewed
Feb 6, 2025
| @@ -2786,6 +2802,7 @@ public class EntityUpdater { | |||
| protected boolean majorVersionChange = false; | |||
| protected final User updatingUser; | |||
| private boolean entityChanged = false; | |||
| @Getter protected ChangeDescription incrementalChangeDescription = null; | |||
There was a problem hiding this comment.
@harshach we will need to introduce the same 'incrementalChangeDescription' field in EntityInterface also
ChangeDescription getIncrementalChangeDescription(); and
void setIncrementalChangeDescription(ChangeDescription incrementalChangeDescription);
this is because when we are making a call to postUpdate and updating the search, we are using
if (entity.getChangeDescription() != null && Objects.equals(entity.getVersion(), entity.getChangeDescription().getPreviousVersion())) {
this needs to be replaced with incrementalChangeDescription as we have removed the consolidated changes for parent.
before making the same changes in pr, i want to confirm if we can go ahead and implement the same in EntityInterface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #17723
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>