Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: fix(migrations): use double question-mark #19557

Merged
merged 1 commit into from
Jan 28, 2025
Merged

MINOR: fix(migrations): use double question-mark #19557

merged 1 commit into from
Jan 28, 2025

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Jan 28, 2025

Use double question mark to escape parametrization by jdbi. https://jdbc.postgresql.org/documentation/query/#using-the-statement-or-preparedstatement-interface

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sushi30 sushi30 requested a review from a team January 28, 2025 08:14
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Jan 28, 2025
@sushi30 sushi30 enabled auto-merge (squash) January 28, 2025 09:28
@mohityadav766 mohityadav766 added the To release Will cherry-pick this PR into the release branch label Jan 28, 2025
@mohityadav766 mohityadav766 merged commit 76c9b5a into main Jan 28, 2025
24 of 29 checks passed
@mohityadav766 mohityadav766 deleted the fix-is-bot-migrations branch January 28, 2025 12:37
@github-actions GitHub Actions
Copy link
Contributor

Failed to cherry-pick changes to the 1.6.3 branch.
Please cherry-pick the changes manually.
You can find more details here.

mohityadav766 pushed a commit that referenced this pull request Jan 28, 2025
@sushi30 @mohityadav766
fix(migrations): use double question-mark (#19557)
5203092 
Use double question mark to escape parametrization by jdbi.
https://jdbc.postgresql.org/documentation/query/#using-the-statement-or-preparedstatement-interface

(cherry picked from commit 76c9b5a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohityadav766 mohityadav766 mohityadav766 approved these changes

Assignees

@sushi30 sushi30

Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sushi30 @mohityadav766