Opensearch connector #19698
Opensearch connector #19698
Conversation
github-actions
bot
added
backend
safe to test
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
Jest test CoverageUI tests summary
|
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
|
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
|
| { | ||
| "$id": "https://open-metadata.org/schema/entity/services/connections/search/elasticSearch/basicAuth.json", | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "title": "Basic Authentication", |
There was a problem hiding this comment.
we should use the common basicAuth schema
| "description": "Authentication for OpenSearch using AWS IAM credentials", | ||
| "type": "object", | ||
| "properties": { | ||
| "awsAccessKeyId": { |
There was a problem hiding this comment.
we should use the common AWS creds schema
| http_auth = aws_auth if aws_auth else (basic_auth if basic_auth else api_key) | ||
|
|
||
| return OpenSearch( | ||
| str(connection.hostPort), |
There was a problem hiding this comment.
we might want to use this instead https://github.com/open-metadata/OpenMetadata/blob/main/ingestion/src/metadata/utils/helpers.py#L359
Describe your changes:
Fixes #19697
I worked on ... because ...
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>