Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the custom test result timestamp in milliseconds #19702

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mtseafood
Copy link

Describe your changes:

This pull request updates the "Test Result" section in the Data Quality Observability Custom Tests documentation. The changes include:

  • Clarifying the JSON payload timestamp format to create and run custom test result.

For more details, refer to the discussion on Slack: Slack Link

What changes did you make?

  • Added a comment explaining the Unix timestamp format for writing TestCaseResults.

Why did you make them?

  • The Unix timestamp in milliseconds is the correct format that the API accepts, ensuring accurate and consistent test results.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@mtseafood mtseafood changed the title Highlight the custom test result timestamp in milliseconds Fix the custom test result timestamp in milliseconds Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants