Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix glossary page performance issue with large number of terms(#19761) #19771

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

juntaozhang
Copy link
Contributor

@juntaozhang juntaozhang commented Feb 13, 2025

Describe your changes:

Fixes #19761

I worked on optimizing the glossary page performance issue because the page was loading very slowly when there were a large number of terms.
I modified the code to use batch methods for setting inherited fields, which significantly reduces the page load time.
I tested the optimization by adding 3000 terms to the glossary page and confirmed that the load time was reduced to less than 1 second.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes 19761: Glossary Page Performance Issue with Large Number of Terms
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link

@juntaozhang juntaozhang changed the title Glossary Page Performance Issue with Large Number of Terms(#19761) Fix glossary page performance issue with large number of terms(#19761) Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glossary Page Performance Issue with Large Number of Terms
3 participants