Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Glossary Approval Workflow #19780

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Update Glossary Approval Workflow #19780

merged 1 commit into from
Feb 14, 2025

Conversation

IceS2
Copy link
Contributor

@IceS2 IceS2 commented Feb 13, 2025

Changing the default Glossary Approval Workflow to make independent the Approval Task from the Has Reviewers test.
The way we have it until now there is only one node that sets the status to approved and if the users want to change how either one of the sides behaves, he is unable to change the other side.

Only the default workflow is changed. There are no migrations to avoid messing with any workflow that could have been changed so far, but the new instances should spin up with this improved format.

You can check the difference in the screenshots below.

CURRENT
image

NEW
image

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link

Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@IceS2 IceS2 merged commit 2f43345 into 1.6.4 Feb 14, 2025
18 of 35 checks passed
@IceS2 IceS2 deleted the update-glossary-workflow branch February 14, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants