Update Glossary Approval Workflow #19780
Merged
+20
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the default Glossary Approval Workflow to make independent the Approval Task from the Has Reviewers test.
The way we have it until now there is only one node that sets the status to approved and if the users want to change how either one of the sides behaves, he is unable to change the other side.
Only the default workflow is changed. There are no migrations to avoid messing with any workflow that could have been changed so far, but the new instances should spin up with this improved format.
You can check the difference in the screenshots below.
CURRENT
![image](https://private-user-images.githubusercontent.com/4912399/412792779-e252eeea-ec7a-42ef-a21a-8dbd11d68475.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MjUyMjQsIm5iZiI6MTczOTYyNDkyNCwicGF0aCI6Ii80OTEyMzk5LzQxMjc5Mjc3OS1lMjUyZWVlYS1lYzdhLTQyZWYtYTIxYS04ZGJkMTFkNjg0NzUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMTMwODQ0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YmI2ODM1ZDYwOTllNzRjZDM5N2EyZmM2YzI0YjYxNzUxOTY2NGIxOTBlNGFiMTllMjg5YTJhMTc0NDdjMWRmMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.qYPT8qZSYI_btFhylAB40B0w9J09iM2zjveI1HnR8Kc)
NEW
![image](https://private-user-images.githubusercontent.com/4912399/412792553-10b3e600-2eac-4f00-abd8-d8802a52a0cc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2MjUyMjQsIm5iZiI6MTczOTYyNDkyNCwicGF0aCI6Ii80OTEyMzk5LzQxMjc5MjU1My0xMGIzZTYwMC0yZWFjLTRmMDAtYWJkOC1kODgwMmE1MmEwY2MucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMTMwODQ0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Zjc2Nzc0ZDk2MzI1ZjU5OWIzNzVlNDZkMmFkOWNmMGVlOTFjZDc3NGU1YTUxM2ZlNDE5MDc5YTQ3ZmEwZDg2MCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.BludMOHxdYv6vuKQE7VwZSb-0jtBLOuoZ9_G4dqfPqA)
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>