Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smsc/accelerator: add new smsc component #12468

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edgargabriel
Copy link
Member

  • add smsc component based on the accelerator API IPC functionality.
  • adjust smsc base selection logic to enable a pass-through mechanism with the new smsc/accelerator component

@edgargabriel edgargabriel force-pushed the topic/smsc-accelerator branch 3 times, most recently from 4c01aee to c44e222 Compare May 2, 2024 17:20
@wenduwan
Copy link
Contributor

wenduwan commented May 2, 2024

@edgargabriel Could you explain how this change can be tested? We can run it through AWS CI.

@edgargabriel
Copy link
Member Author

@wenduwan Assuming that you do not have AMD GPUs, I think the prerequisite for testing this PR would require the accelerator/cuda component to implement the missing IPC functionality.

@edgargabriel edgargabriel force-pushed the topic/smsc-accelerator branch 3 times, most recently from 1e72876 to 8e3d21f Compare May 2, 2024 17:59
@bosilca bosilca self-assigned this May 2, 2024
@bosilca
Copy link
Member

bosilca commented May 2, 2024

Give me a week or so to add support for CUDA.

@edgargabriel
Copy link
Member Author

btw. I have no clue why the continuous-integration/jenkins/pr-head is marked as 'failed'. If you click on Details, all tests seemed to have passed correctly

@wenduwan
Copy link
Contributor

wenduwan commented May 6, 2024

distcheck failed

make[5]: Entering directory '/home/ubuntu/workspace/pen-mpi.pull_request-v2_PR-12468/opal/mca/smsc/accelerator'

make  distdir-am

make[6]: Entering directory '/home/ubuntu/workspace/pen-mpi.pull_request-v2_PR-12468/opal/mca/smsc/accelerator'

make[6]: *** No rule to make target 'post_configure.sh', needed by 'distdir-am'.  Stop.

make[6]: Leaving directory '/home/ubuntu/workspace/pen-mpi.pull_request-v2_PR-12468/opal/mca/smsc/accelerator'

make[5]: *** [Makefile:1585: distdir] Error 2

make[5]: Leaving directory '/home/ubuntu/workspace/pen-mpi.pull_request-v2_PR-12468/opal/mca/smsc/accelerator'

make[4]: *** [Makefile:2029: distdir-am] Error 1

make[4]: Leaving directory '/home/ubuntu/workspace/pen-mpi.pull_request-v2_PR-12468/opal'

make[3]: *** [Makefile:2025: distdir] Error 2

make[3]: Leaving directory '/home/ubuntu/workspace/pen-mpi.pull_request-v2_PR-12468/opal'

make[2]: *** [Makefile:1604: distdir-am] Error 1

make[2]: Leaving directory '/home/ubuntu/workspace/pen-mpi.pull_request-v2_PR-12468'

make[1]: *** [Makefile:1598: distdir] Error 2

make[1]: Leaving directory '/home/ubuntu/workspace/pen-mpi.pull_request-v2_PR-12468'

make: *** [Makefile:1702: dist] Error 2

script returned exit code 2

@wenduwan
Copy link
Contributor

wenduwan commented May 6, 2024

I find jenkins pipeline graph visually misleading. The pipeline steps page shows the failure
https://jenkins.open-mpi.org/jenkins/job/open-mpi.pull_request-v2/job/PR-12468/7/flowGraphTable/

@edgargabriel
Copy link
Member Author

@wenduwan thank you, will need to check, probably forgot to add a file somewhere

- add smsc component based on the accelerator API IPC functionality.
- adjust smsc base selection logic to enable a pass-through mechanism
  with the new smsc/accelerator component

Signed-off-by: Edgar Gabriel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants