Big Count: first pass for coll framework bc #12539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devreal
requested changes
May 9, 2024
Is there a reason to not use |
|
|
devreal
approved these changes
May 13, 2024
There was a problem hiding this comment.
Thanks @hppritcha! My picky clang didn't find any warnings related to these changes.
This commit adds only those functions which make use of C integer promotion. So none of the 'v,w' and reduce_scatter related methods are added in this PR. Related to open-mpi#12336 Pieces of open-mpi#12478 were taken out to make this PR. Signed-off-by: Howard Pritchard <[email protected]>
hppritcha
force-pushed
the
coll-framework-bigcount-intpromo
branch
from
118a843
to
4d7c65d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds only those functions which make use of C integer promotion. So none of the 'v,w' and reduce_scatter related methods are added in this PR.
Related to #12336
Pieces of #12478 were taken out to make this PR.