Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

romio314: do not link with cudart #12921

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Nov 14, 2024

identical to #9144 for libcuda, applied to libcudart as well

This commit forces ROMIO to not detect cudart at configure time by using setting the hidden/undocumented ac_cv_lib_cudart_cudaStreamSynchronize=no variable before invoking ROMIO's configure.

Refs:

Signed-off-by: Min RK [email protected]

Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

da50c9d: romio314: do not link with cudart

  • check_signed_off: does not contain a valid Signed-off-by line

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@minrk
Copy link
Contributor Author

minrk commented Nov 15, 2024

I'm not sure how syncing with upstream works, but fwiw current MPL (since mpich 4.0, I think) uses a newer PAC_CHECK_HEADER_LIB_OPTIONAL, which looks like it would allow --with-cuda=no to stop looking for and linking libcuda and libcudart instead of setting these ac_cv_ variables.

@ggouaillardet
Copy link
Contributor

FWIW #12640 is a romio updrade (from MPICH 4.2.1). It is still a draft because I had no time to test it.
I think the job is done though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants