Skip to content

Commit

Permalink
fix typos
Browse files Browse the repository at this point in the history
  • Loading branch information
mbeckem committed Jun 29, 2024
1 parent b31a7e2 commit 342b222
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion .changeset/ninety-glasses-fix.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"@open-pioneer/chakra-integration": major
---

Rename `container` prop to `rootNode`. This property refers to the application's shadow root and was misnamed.
Rename the `container` prop of the `CustomChakraProvider` to `rootNode`.
This property refers to the application's shadow root and was misnamed.
Introduce `container` prop that refers to the application's container element (the root html element inside the shadow root).
4 changes: 2 additions & 2 deletions .changeset/wicked-cats-vanish.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ It now looks like this:
└── <div class="pioneer-root chakra-host">
```

Since all UI elements where already children of the `.chakra-host` element, this should not affect most applications.
Since all UI elements were already children of the `.chakra-host` element, this should not affect most applications.

The presence of two node made it possible to accidentally create a node where Chakra's style rules didn't apply.
The presence of two nodes made it possible to accidentally create a node where Chakra's style rules didn't apply.
This change prevents that error.

0 comments on commit 342b222

Please sign in to comment.