refactoring schema errors

Signed-off-by: Jaydip Gabani <[email protected]>

constraint/pkg/client/drivers/k8scel/schema/errors.go

@@ -6,4 +6,8 @@ var (
 	ErrBadMatchCondition = errors.New("invalid match condition")
 	ErrBadVariable       = errors.New("invalid variable definition")
 	ErrBadFailurePolicy  = errors.New("invalid failure policy")
+	ErrCodeNotDefined    = errors.New("K8sNativeValidation code not defined")
+	ErrOneTargetAllowed  = errors.New("wrong number of targets defined, only 1 target allowed")
+	ErrBadType           = errors.New("Could not recognize the type")
+	ErrMissingField      = errors.New("K8sNativeValidation source missing required field")
 )

constraint/pkg/client/drivers/k8scel/schema/schema.go

@@ -1,7 +1,6 @@
 package schema
 
 import (
-	"errors"
 	"fmt"
 	"strings"
 
@@ -26,11 +25,6 @@ const (
 	ObjectName = "anyObject"
 )
 
-var (
-	ErrBadType      = errors.New("Could not recognize the type")
-	ErrMissingField = errors.New("K8sNativeValidation source missing required field")
-)
-
 type Validation struct {
 	// A CEL expression. Maps to ValidationAdmissionPolicy's `spec.validations`.
 	Expression        string `json:"expression,omitempty"`
@@ -278,7 +272,7 @@ func GetSource(code templates.Code) (*Source, error) {
 
 func GetSourceFromTemplate(ct *templates.ConstraintTemplate) (*Source, error) {
 	if len(ct.Spec.Targets) != 1 {
-		return nil, errors.New("wrong number of targets defined, only 1 target allowed")
+		return nil, ErrOneTargetAllowed
 	}
 
 	var source *Source
@@ -294,7 +288,7 @@ func GetSourceFromTemplate(ct *templates.ConstraintTemplate) (*Source, error) {
 		break
 	}
 	if source == nil {
-		return nil, errors.New("K8sNativeValidation code not defined")
+		return nil, ErrCodeNotDefined
 	}
 	return source, nil
 }