Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumping opa 0.66.0 to 0.67.0 #459

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

JaydipGabani
Copy link
Contributor

No description provided.

Signed-off-by: Jaydip Gabani <[email protected]>
Signed-off-by: Jaydip Gabani <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.80%. Comparing base (76869f8) to head (fb932e3).
Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
- Coverage   54.68%   53.80%   -0.89%     
==========================================
  Files          71      104      +33     
  Lines        5241     6745    +1504     
==========================================
+ Hits         2866     3629     +763     
- Misses       2073     2745     +672     
- Partials      302      371      +69     
Flag Coverage Δ
unittests 53.80% <ø> (-0.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritazh
Copy link
Member

ritazh commented Jul 31, 2024

Testing failures:

go test -mod vendor ./pkg/... ./apis/... ./cmd/gator/... -race -bench . -coverprofile cover.out
# go.opentelemetry.io/otel/sdk/metric
Error: vendor/go.opentelemetry.io/otel/sdk/metric/meter.go:63:22: cannot use (*meter)(nil) (value of type *meter) as "go.opentelemetry.io/otel/metric".Meter value in variable declaration: *meter does not implement "go.opentelemetry.io/otel/metric".Meter (missing method Float64Gauge)
Error: vendor/go.opentelemetry.io/otel/sdk/metric/provider.go:101:9: cannot use mp.meters.Lookup(s, func() *meter {…}) (value of type *meter) as "go.opentelemetry.io/otel/metric".Meter value in return statement: *meter does not implement "go.opentelemetry.io/otel/metric".Meter (missing method Float64Gauge)
# github.com/open-policy-agent/gatekeeper/v3/pkg/gator
Error: pkg/gator/client.go:32:63: undefined: drivers.QueryOpt
# github.com/open-policy-agent/gatekeeper/v3/pkg/target [github.com/open-policy-agent/gatekeeper/v3/pkg/target.test]
Error: pkg/target/target_integration_test.go:471:47: undefined: drivers.Tracing
Error: pkg/target/target_integration_test.go:500:49: undefined: drivers.Tracing
Error: pkg/target/target_integration_test.go:513:49: undefined: drivers.Tracing

@JaydipGabani
Copy link
Contributor Author

JaydipGabani commented Jul 31, 2024

Testing failures:

go test -mod vendor ./pkg/... ./apis/... ./cmd/gator/... -race -bench . -coverprofile cover.out
# go.opentelemetry.io/otel/sdk/metric
Error: vendor/go.opentelemetry.io/otel/sdk/metric/meter.go:63:22: cannot use (*meter)(nil) (value of type *meter) as "go.opentelemetry.io/otel/metric".Meter value in variable declaration: *meter does not implement "go.opentelemetry.io/otel/metric".Meter (missing method Float64Gauge)
Error: vendor/go.opentelemetry.io/otel/sdk/metric/provider.go:101:9: cannot use mp.meters.Lookup(s, func() *meter {…}) (value of type *meter) as "go.opentelemetry.io/otel/metric".Meter value in return statement: *meter does not implement "go.opentelemetry.io/otel/metric".Meter (missing method Float64Gauge)
# github.com/open-policy-agent/gatekeeper/v3/pkg/gator
Error: pkg/gator/client.go:32:63: undefined: drivers.QueryOpt
# github.com/open-policy-agent/gatekeeper/v3/pkg/target [github.com/open-policy-agent/gatekeeper/v3/pkg/target.test]
Error: pkg/target/target_integration_test.go:471:47: undefined: drivers.Tracing
Error: pkg/target/target_integration_test.go:500:49: undefined: drivers.Tracing
Error: pkg/target/target_integration_test.go:513:49: undefined: drivers.Tracing

@ritazh This test is expected to fail because the recent frameworks changes for scopedEnforcementActions are still not available in Gatekeeper. Should get resolved after - gatekeeper/pull/3321

Looking into otel test failures

@JaydipGabani
Copy link
Contributor Author

Otel test failures should be fixed once we bump sdk/metric in go.mod on gatekeeper with opa bump.

@ritazh
Copy link
Member

ritazh commented Aug 1, 2024

Otel test failures should be fixed once we bump sdk/metric in go.mod on gatekeeper with opa bump.

can you push a GK PR with the proposed change so we can validate the bump fixes the issue? thank you!

@JaydipGabani
Copy link
Contributor Author

@ritazh Bumping otel in this PR - gatekeeper/#3469

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritazh ritazh merged commit 6ec97ba into open-policy-agent:master Aug 1, 2024
7 of 8 checks passed
@JaydipGabani JaydipGabani deleted the bump-rego branch August 2, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants