feat: stats in webhook, audit & gator #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsmythe
reviewed
Apr 10, 2023
acpana
force-pushed
the
acpana/gator-stats
branch
from
1ce1c9f to
e85f1b1
Compare
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
acpana
force-pushed
the
acpana/gator-stats
branch
from
e85f1b1 to
14c792f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2686 +/- ##
==========================================
+ Coverage 52.76% 52.80% +0.04%
==========================================
Files 123 125 +2
Lines 10941 11053 +112
==========================================
+ Hits 5773 5837 +64
- Misses 4711 4759 +48
Partials 457 457
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@maxsmythe PTAL 🙏🏼 |
maxsmythe
reviewed
Apr 21, 2023
davis-haba
reviewed
Apr 21, 2023
davis-haba
reviewed
Apr 21, 2023
davis-haba
reviewed
Apr 21, 2023
|
LGTM with nits (after Max's comments are addressed about the output file flag and skipping self-validation in g8r) We should update the docs too, but this can be done as a follow up if you prefer. |
davis-haba
reviewed
Apr 21, 2023
davis-haba
reviewed
Apr 21, 2023
Signed-off-by: Alex Pana <[email protected]>
acpana
force-pushed
the
acpana/gator-stats
branch
from
92ab0e8 to
f2f1026
Compare
|
regarding
I was planning on updating the docs separately. |
maxsmythe
reviewed
Apr 26, 2023
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
maxsmythe
reviewed
May 4, 2023
maxsmythe
reviewed
May 4, 2023
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
sozercan
reviewed
May 8, 2023
pkg/logging/logging_test.go
Outdated
| } | ||
|
|
||
| func (c *fakeCore) Sync() error { | ||
| return nil // TODO(acpana): revisit implementation for GC |
There was a problem hiding this comment.
before we merge, can we open an issue tracking this?
sozercan
reviewed
May 8, 2023
sozercan
reviewed
May 8, 2023
| @@ -62,6 +62,7 @@ var ( | |||
| auditMatchKindOnly = flag.Bool("audit-match-kind-only", false, "only use kinds specified in all constraints for auditing cluster resources. if kind is not specified in any of the constraints, it will audit all resources (same as setting this flag to false)") | |||
| apiCacheDir = flag.String("api-cache-dir", defaultAPICacheDir, "The directory where audit from api server cache are stored, defaults to /tmp/audit") | |||
| emptyAuditResults []updateListEntry | |||
| logStatsAudit = flag.Bool("log-stats-audit", false, "(alpha) log stats metrics for the audit run") | |||
There was a problem hiding this comment.
can we add a doc to describe usage? can be a follow-up
sozercan
reviewed
May 8, 2023
| ) | ||
|
|
||
| func init() { | ||
| Cmd.Flags().StringArrayVarP(&flagFilenames, flagNameFilename, "f", []string{}, "a file or directory containing Kubernetes resources. Can be specified multiple times.") | ||
| Cmd.Flags().StringVarP(&flagOutput, flagNameOutput, "o", "", fmt.Sprintf("Output format. One of: %s|%s.", stringJSON, stringYAML)) | ||
| Cmd.Flags().BoolVarP(&flagIncludeTrace, "trace", "t", false, `include a trace for the underlying constraint framework evaluation`) | ||
| Cmd.Flags().BoolVarP(&flagIncludeTrace, "trace", "t", false, "include a trace for the underlying Constraint Framework evaluation.") |
There was a problem hiding this comment.
can we add a doc that describes usage? can be a follow up
There was a problem hiding this comment.
yes for stats feature I was going to do a follow up docs PR.
sozercan
reviewed
May 8, 2023
sozercan
approved these changes
May 8, 2023
acpana
commented
May 9, 2023
acpana
commented
May 9, 2023
acpana
commented
May 9, 2023
Co-authored-by: Sertaç Özercan <[email protected]> Signed-off-by: alex <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
This was referenced May 10, 2023
anlandu
pushed a commit
to anlandu/gatekeeper
that referenced
this pull request
May 19, 2023
Signed-off-by: Alex Pana <[email protected]> Signed-off-by: alex <[email protected]> Co-authored-by: Sertaç Özercan <[email protected]> Signed-off-by: Anlan Du <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates
statsunder flags foradmission,audit&gator test. This should be viewed as an iterative process and we can revisit the emission mechanism (ie logging) or think about aggregation or prometheus metrics, etc. in follow ups.Docs will come as a follow up once code lands.