Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added .Values.validatingWebhookExemptNamespacesLabels to the /v1/admitlabel webhook #3147

Closed
wants to merge 5 commits into from
Closed

fix: Added .Values.validatingWebhookExemptNamespacesLabels to the /v1/admitlabel webhook #3147

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4763d8b
added validatingWebhookExemptNamespacesLabels to admitlabel webhook
Gaardsholt Nov 6, 2023
667c812
Revert "added validatingWebhookExemptNamespacesLabels to admitlabel w…
Gaardsholt Nov 7, 2023
8d814eb
changing the chart the correct way
Gaardsholt Nov 7, 2023
29de8fd
hopefully made the changes the correct way now
Gaardsholt Nov 21, 2023
8e67093
Merge branch 'master' into validatingWebhookExemptNamespacesLabels
JaydipGabani Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
hopefully made the changes the correct way now 
Signed-off-by: Lasse Gaardsholt <[email protected]>
  • Loading branch information
@Gaardsholt
Gaardsholt committed Nov 27, 2023
commit 29de8fd1f2c8be4c478965fa33d3c5b7149d753c
1 change: 1 addition & 0 deletions cmd/build/helmify/kustomize-for-helm.yaml
View file
Original file line number Diff line number Diff line change
@@ -288,6 +288,7 @@ webhooks:
namespaceSelector:
matchExpressions:
- HELMSUBST_VALIDATING_WEBHOOK_MATCHEXPRESSION_METADATANAME
- HELMSUBST_VALIDATING_WEBHOOK_EXEMPT_NAMESPACE_LABELS
timeoutSeconds: HELMSUBST_VALIDATING_WEBHOOK_TIMEOUT
failurePolicy: HELMSUBST_VALIDATING_WEBHOOK_CHECK_IGNORE_FAILURE_POLICY
---
4 changes: 2 additions & 2 deletions ...templates/gatekeeper-validating-webhook-configuration-validatingwebhookconfiguration.yaml
View file
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ webhooks:
operator: NotIn
values:
- {{ .Release.Namespace }}

{{- range $key, $value := .Values.validatingWebhookExemptNamespacesLabels}}
- key: {{ $key }}
operator: NotIn
@@ -98,7 +98,7 @@ webhooks:
operator: NotIn
values:
- {{ .Release.Namespace }}

{{- range $key, $value := .Values.validatingWebhookExemptNamespacesLabels}}
- key: {{ $key }}
operator: NotIn