refactor: remove gomega #3169
Closed
refactor: remove gomega #3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acpana
changed the title
Signed-off-by: Alex Pana <[email protected]>
acpana
force-pushed
the
acpana/remove-gomega-r
branch
from
9224e64 to
6431504
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3169 +/- ##
=======================================
Coverage 53.75% 53.76%
=======================================
Files 136 136
Lines 12198 12198
=======================================
+ Hits 6557 6558 +1
Misses 5138 5138
+ Partials 503 502 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JaydipGabani
approved these changes
Jan 22, 2024
|
Closing this as acpana's attention is now elsewhere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gomegafromgatekeeperas it's only used for async assertions and we can cover all use cases with existingrequire/assertlibs.