Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add connect to operations #3785

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

malexander2012
Copy link

@malexander2012 malexander2012 commented Jan 16, 2025

What this PR does / why we need it:
This adds connect to the operations doc.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes # N/A

Yes No Yes

Special notes for your reviewer:
Not sure what else to put in the Required Behaviors and Permissions Required. Need a little help here.

@malexander2012 malexander2012 requested a review from a team as a code owner January 16, 2025 20:38
@malexander2012 malexander2012 changed the title doc: Add connect to operations docs: Add connect to operations Jan 16, 2025
Copy link
Contributor

@JaydipGabani JaydipGabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malexander2012 operation.md refers to all the operations that gatekeeper supports, here is the list of it - https://github.com/open-policy-agent/gatekeeper/blob/master/pkg/operations/operations.go#L18. We enable gk webhooks to allow validation of connect operations - https://github.com/open-policy-agent/gatekeeper/blob/master/charts/gatekeeper/templates/gatekeeper-validating-webhook-configuration-validatingwebhookconfiguration.yaml#L68 recently. We should close this PR if the interntion was to update the GK docs with latest information about supported operations.

@ritazh
Copy link
Member

ritazh commented Jan 17, 2025

You can add a new section for “how to enable validation of connect operations”, similar to: https://open-policy-agent.github.io/gatekeeper/website/docs/customize-admission/#how-to-enable-validation-of-delete-operations

@malexander2012
Copy link
Author

You can add a new section for “how to enable validation of connect operations”, similar to: https://open-policy-agent.github.io/gatekeeper/website/docs/customize-admission/#how-to-enable-validation-of-delete-operations

Sure thing. I'll add that section below the section you referenced. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants