refact: uuid func, new otelgrpc #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
reviewed
Jan 9, 2025
|
Yeah I was surprised, too -- why do we not use one of the common 3rd party deps here? It's not like there weren't at least two in the dependency tree anyways. 😉 |
Signed-off-by: Anthony Regeda <[email protected]>
I've imported 3rd party library for uuid purposes. |
| @@ -159,8 +159,7 @@ func New(m *plugins.Manager, cfg *Config) plugins.Plugin { | |||
| otelhttp.WithPropagators(propagation.NewCompositeTextMapPropagator(propagation.TraceContext{}, propagation.Baggage{}, b3.New(b3.WithInjectEncoding(b3.B3MultipleHeader|b3.B3SingleHeader)))), | |||
| ) | |||
| grpcOpts = append(grpcOpts, | |||
| grpc.UnaryInterceptor(otelgrpc.UnaryServerInterceptor(grpcTracingOption...)), | |||
| grpc.StreamInterceptor(otelgrpc.StreamServerInterceptor(grpcTracingOption...)), | |||
| grpc.StatsHandler(otelgrpc.NewServerHandler(grpcTracingOption...)), | |||
There was a problem hiding this comment.
Can you please explain this change?
There was a problem hiding this comment.
Both otelgrpc.UnaryServerInterceptor and otelgrpc.StreamServerInterceptor are deprecated.
Use NewServerHandler instead.
ashutosh-narkar
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
util.UUID4function bygoogle/uuidpackage.Benchmark results
Before:
After: