adds S/NTRUP1277

[baentsch]

Fixes #1108

• Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
• Does this PR change the the list of algorithms available -- either adding, removing, or renaming? (If so, PRs in OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also be required by the time this is merged.)

Add/Edit:

• OpenSSL PR: adding ntrup1277 openssl#334
• OpenSSH PR: added s/ntrup1277 openssh#112
• BoringSSL PR: added s/ntrup1277 boringssl#75
• oqs-provider PR will follow after Implement encoder and decoder oqs-provider#34 landed (too many conflicts otherwise)

[baentsch]

Would someone with a Mac have time to look into the apparently Apple-specific length limitation failing CI? In the worst case, I will disable some algorithms from the default build on OSX to get this to pass on that platform. (Other) Proposals welcome. Thanks in advance.

[dstebila]

I'm unable to reproduce on my system; I even tried downgrading to the exact version of CMake used on CircleCI but that didn't make it happen.

I tried some of the ideas I found by Googling: 1, 2, in particular adding the following lines to CMakeList.txt:

# avoid too-long command lines
# https://stackoverflow.com/questions/43184251/cmake-command-line-too-long-windows
set(CMAKE_C_USE_RESPONSE_FILE_FOR_OBJECTS 1)
set(CMAKE_C_RESPONSE_FILE_LINK_FLAG "@")
set(CMAKE_NINJA_FORCE_RESPONSE_FILE 1 CACHE INTERNAL "")

but then I got a build failure. Link 2 above actually comments that it's tricky to make this work reliably. I'm not sure what to suggest.

[baentsch]

I'm unable to reproduce on my system [...] I'm not sure what to suggest.

Thanks for running it on your system. If it's working there this is a CircleCI issue and putting work on fixing that isn't really worth the effort. What about simply disabling a family for shared OSX CCI runs? What about McEliece? Would also speed up CI considerably. WillDid put a note into the platform-specific build Wiki .

[dstebila]

Thanks for running it on your system. If it's working there this is a CircleCI issue and putting work on fixing that isn't really worth the effort.

Hard to tell where the problem is at this point, so:

What about simply disabling a family for shared OSX CCI runs? What about McEliece? Would also speed up CI considerably.

Yeah I guess that would be fine for now.

[dstebila]

Thanks Michael!