Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test.openquantumsafe.org & resolve some issues #223

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

bhess
Copy link
Member

@bhess bhess commented Aug 8, 2023

Updates the build for test.openquantumsafe.org:

  • Updates oqs-provider to 0.5.1

Fixes a few issues:

  • ssl groups for OQS-kems were not correctly resolved to strings.

Example:

/curl -v --cacert cert.pem --curves x25519_kyber512:kyber768 https://test.openquantumsafe.org:6245/
...
Client-side KEM algorithm(s) indicated:
0x2f39:0x023c

The update resolves them correctly:

/curl -v --cacert cert.pem --curves x25519_kyber512:kyber768 https://test.openquantumsafe.org:6245/
...
Client-side KEM algorithm(s) indicated:
x25519_kyber512:kyber768

-> needed to patch nginx to use SSL_group_to_name instead OBJ_nid2sn when using OpenSSL >= 3.0.

  • signature/kem response was not available with the ports that offer the default groups. Example:
    https://test.openquantumsafe.org:6043 returned Successfully connected using !. With the update it returns Successfully connected using rsa3072-x25519!

-> updated interop.conf to not hardcode the negotiated group in the response html but instead use nginx's $ssl_curve variable available from v1.21.5. Also needed to patch nginx to correctly resolve the string when using OpenSSL >= 3.0.

  • server html response was malformed (missing </html> tag)

The update is already applied to https://test.openquantumsafe.org.
May see if there is interest in nginx upstream to apply the patch there.

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the improvements.

@bhess bhess merged commit 5a087e4 into main Aug 23, 2023
7 checks passed
@bhess bhess deleted the bhe-toqs-upd branch August 23, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants