Bring QUIC Back #291

pi-314159 · 2024-08-12T09:27:46Z

No description provided.

pi-314159 · 2024-08-12T17:52:57Z

@bhess @baentsch Could you take a look at this?

Co-authored-by: Raytonne <[email protected]> Co-authored-by: lxwzy <[email protected]> Co-authored-by: pi-314159 <[email protected]> Signed-off-by: pi-314159 <[email protected]>

baentsch · 2024-08-13T13:06:43Z

nginx/README-QUIC.md

+docker build -f Dockerfile-QUIC .
+```
+
+After building, remember the SHA256 hash of the image from the last line of the output.


This looks complicated: Why not built to a name (and reference that below)?

baentsch · 2024-08-13T13:06:54Z

nginx/README-QUIC.md

+- **Without Port Forwarding:**
+
+  ```bash
+  docker run -d SHA256_OF_THE_IMAGE


baentsch · 2024-08-13T13:07:05Z

nginx/README-QUIC.md

+- **With Port Forwarding:**
+
+  ```bash
+  docker run -d -p 80:80 -p 443:443 -p 443:443/udp SHA256_OF_THE_IMAGE


baentsch · 2024-08-13T13:08:42Z

nginx/README-QUIC.md

+
+Replace `CONTAINER_ID` with the ID obtained from the previous step.
+
+Inside the container, nginx configuration files are located in `/etc/nginx`, and the nginx executable is at `/usr/sbin/nginx`.


Hmm -- this leaves users pretty much at their own devices... Other demos have USAGE.md files to help people getting going...

partially fixed by providing an example server configuration...
I think it's straightforward for users who have used nginx before...

baentsch · 2024-08-13T13:10:49Z

Thanks for the new integration @pi-314159 ! Do I get it right that this drops a QUIC-enabled client- and server- demo adding back only a server side?

Edit/add: I guess what I'm asking for is a (new) USAGE-QUIC.md file that tells people simply running the binary dockerimage how they can test-drive (and configure for all supported alg combinations) the image? Or don't you want to make this possible (as also the docker build-and-push CI commands are missing)?

bhess · 2024-08-13T13:12:17Z

Thank you for adding this QUIC-demo @pi-314159, this is really useful also as addition to the test server. Also tagging @ajbozarth who is looking at updating the oqs-demos.

Two remarks:

Does USAGE.md warrant an update? (e.g. how to connect to nginx-quic with a client)
Since this removes the demo in the quic-folder, does it provide the same functionality?

baentsch · 2024-08-13T13:24:26Z

this is really useful also as addition to the test server

Are you going to deploy this on the IBM test server instance @bhess or are you expecting someone else to write code, config and documentation?

bhess · 2024-08-13T13:29:28Z

Are you going to deploy this on the IBM test server instance @bhess

This was my thinking.

pi-314159 · 2024-08-13T13:50:09Z

@baentsch @bhess

Does USAGE.md warrant an update? (e.g. how to connect to nginx-quic with a client)

I'll add a QUIC enabled curl Dockerfile in the curl folder after this PR gets merged.

Since this removes the demo in the quic-folder, does it provide the same functionality?

Previously, we were using quictls; BoringSSL lacked support for some algorithms. However, I plan to add hybrid algorithm implementations to BoringSSL this week.

Edit/add: I guess what I'm asking for is a (new) USAGE-QUIC.md file that tells people simply running the binary dockerimage how they can test-drive (and configure for all supported alg combinations) the image? Or don't you want to make this possible (as also the docker build-and-push CI commands are missing)?

One reason I didn't add such feature is that BoringSSL's bssl don't support creating X509 certificates. This means I'd also need to build the oqs-provider to generate a test certificate, which adds extra complexity. Instead, I can provide an nginx-quic-example.conf file to help with this.

Signed-off-by: PI <[email protected]>

baentsch

I'll add a QUIC enabled curl Dockerfile in the curl folder after this PR gets merged.

First removing the (old) QUIC demo completely before adding back functionality that has been removed doesn't sound good. If you'd like to proceed that way (this PR first, another PR later), then please remove the "quic removal" logic from this PR and add it to the second PR so we know the for sure we have a new demo replacing the old one functionally.

Signed-off-by: PI <[email protected]>

pi-314159 · 2024-08-19T09:21:42Z

@baentsch and @bhess added curl

baentsch · 2024-08-19T12:44:00Z

@pi-314159 Thanks for the curl addition! I now pushed your code into the OQS repo. 2 reasons: 1) See CI run (hopefully not fail) and 2) ask you to check whether you now have the permissions to keep working on that branch (open-quantum-safe/tsc@e73b3d2 should have given you those rights). If that'd be OK, it'd be great if your new contributions could be done straight within OQS/oqs-demos such as for your jobs to also use the docker credentials upon push/PR. On that topic: Do you intend to add code to build and push the docker images? If so, also some code to test the resultant images? Examples for build-and-push in https://github.com/open-quantum-safe/oqs-demos/blob/main/.github/workflows/linux.yml and for testing in

oqs-demos/.circleci/config.yml

Lines 87 to 93 in e810c8a

    
                 - run: 
        
                     name: Test nginx and curl generic 
        
                     command: | 
        
                       docker network create nginx-test && 
        
                       docker run --network nginx-test --detach --rm --name oqs-nginx oqs-nginx-img && 
        
                       sleep 2 && 
        
                       docker run --network nginx-test oqs-curl-generic curl -k https://oqs-nginx:4433

(the latter of course just as reference; actual testing should be in GH CI as we want to move off CCI).

pi-314159 · 2024-08-20T21:39:10Z

@baentsch I have the permission to merge.

I'm not very familiar with GitHub CI at the moment, so I'll take care of adding the code to build and push the Docker images a bit later. If that works for you, I'll go ahead and merge it now.

Also, please check the boringssl PR

baentsch · 2024-08-21T07:29:09Z

I'll take care of adding the code to build and push the Docker images a bit later.

Created #294 to do this "for good" for all docker image creation. So please add your code only to GH workflow files.

I'll go ahead and merge it now.

I'd have preferred to check everything's working locally (say in a docker network), but I assume you did (?) and don't find the time myself right now, so go ahead.

pi-314159 · 2024-08-21T07:48:31Z

I assume you did (?) and don't find the time myself right now, so go ahead.

Yes I've tested these Dockerfiles on my machine. Please test them when you have time!

Signed-off-by: PI <[email protected]>

Add nginx with QUIC Dockerfile

5f56576

Co-authored-by: Raytonne <[email protected]> Co-authored-by: lxwzy <[email protected]> Co-authored-by: pi-314159 <[email protected]> Signed-off-by: pi-314159 <[email protected]>

pi-314159 force-pushed the nginx-quic-20240812 branch from b1df763 to 5f56576 Compare August 13, 2024 03:22

baentsch requested changes Aug 13, 2024

View reviewed changes

update

809320b

Signed-off-by: PI <[email protected]>

dstebila mentioned this pull request Aug 14, 2024

Give pi-314159 write access on oqs-demos open-quantum-safe/tsc#65

Closed

pi-314159 requested a review from baentsch August 19, 2024 05:19

baentsch requested changes Aug 19, 2024

View reviewed changes

curl with http3 support

04f7799

Signed-off-by: PI <[email protected]>

pi-314159 requested a review from baentsch August 19, 2024 09:21

pi-314159 linked an issue Aug 19, 2024 that may be closed by this pull request

Add QUIC support #261

Closed

pi-314159 self-assigned this Aug 19, 2024

baentsch mentioned this pull request Aug 21, 2024

Build failures in CI #277

Closed

pi-314159 changed the title ~~Add nginx with QUIC Dockerfile~~ Bring cURL Back Aug 21, 2024

README.md (minor edit)

212d4f2

Signed-off-by: PI <[email protected]>

pi-314159 merged commit 3725dba into open-quantum-safe:main Aug 21, 2024
2 of 4 checks passed

pi-314159 deleted the nginx-quic-20240812 branch August 21, 2024 08:04

pi-314159 changed the title ~~Bring cURL Back~~ Bring QUIC Back Aug 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bring QUIC Back #291

Bring QUIC Back #291

pi-314159 commented Aug 12, 2024

pi-314159 commented Aug 12, 2024

baentsch Aug 13, 2024

pi-314159 Aug 13, 2024

baentsch Aug 13, 2024

pi-314159 Aug 13, 2024

baentsch Aug 13, 2024

pi-314159 Aug 13, 2024

baentsch Aug 13, 2024

pi-314159 Aug 13, 2024

baentsch commented Aug 13, 2024 •

edited

Loading

bhess commented Aug 13, 2024

baentsch commented Aug 13, 2024

bhess commented Aug 13, 2024

pi-314159 commented Aug 13, 2024

baentsch left a comment

pi-314159 commented Aug 19, 2024

baentsch commented Aug 19, 2024

pi-314159 commented Aug 20, 2024

baentsch commented Aug 21, 2024

pi-314159 commented Aug 21, 2024


		Replace `CONTAINER_ID` with the ID obtained from the previous step.

		Inside the container, nginx configuration files are located in `/etc/nginx`, and the nginx executable is at `/usr/sbin/nginx`.

Bring QUIC Back #291

Bring QUIC Back #291

Conversation

pi-314159 commented Aug 12, 2024

pi-314159 commented Aug 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

baentsch commented Aug 13, 2024 • edited Loading

bhess commented Aug 13, 2024

baentsch commented Aug 13, 2024

bhess commented Aug 13, 2024

pi-314159 commented Aug 13, 2024

baentsch left a comment

Choose a reason for hiding this comment

pi-314159 commented Aug 19, 2024

baentsch commented Aug 19, 2024

pi-314159 commented Aug 20, 2024

baentsch commented Aug 21, 2024

pi-314159 commented Aug 21, 2024

baentsch commented Aug 13, 2024 •

edited

Loading