Include use of loaded 'libctx' context in KEM and SIG procedures (#557) #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-quantum-safe#557) Signed-off-by: RodriM11 <[email protected]>
baentsch
reviewed
Jan 4, 2025
|
CI failure seems relevant @RodriM11 |
|
Weird that only happens on MSVC... I will take a look at it, although I don't have a local MSVC environment to test. |
Signed-off-by: RodriM11 <[email protected]>
|
I found the problem on MSVC and tests now run correctly on my local MSVC environment. I have uploaded the changes, along with your suggestion regarding the input to the DRBG procedures, @baentsch. |
|
Thanks for your help @baentsch! As we talked, I will now open an issue in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inclusion of use of OSSL_LIB_CTX * context in which the oqsprovider is loaded to KeyGen, Encaps, Decaps (KEM) and KeyGen, Sign, Verify (SIG) (classical) operations, along with a explicit test to verify this behavior.
This PR is associated with issue #557.