Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use same empty string default value as fleet adapter launches #237

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Use same empty string default value as fleet adapter launches #237

merged 1 commit into from
Jun 5, 2024

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Jun 5, 2024 •
edited
Loading

Bug fix

Fixed bug

Fix issue mentioned in #230, which causes undesired logging when server URI is not found by using same empty string default vaue as fleet adapter launches

@aaronchongth aaronchongth requested a review from mxgrey June 5, 2024 05:05
mxgrey
mxgrey approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for responding to the issue so quickly!

@mxgrey mxgrey enabled auto-merge (squash) June 5, 2024 05:06
@mxgrey mxgrey disabled auto-merge June 5, 2024 06:00
@mxgrey mxgrey merged commit 6a27d7c into main Jun 5, 2024
2 checks passed
@mxgrey mxgrey deleted the ws-default-uri branch June 5, 2024 06:00
aaronchongth added a commit that referenced this pull request Jun 19, 2024
@aaronchongth
Use same empty string default value as fleet adapter launches (#237)
5999e2e 
Signed-off-by: Aaron Chong <[email protected]>
(cherry picked from commit 6a27d7c)
Signed-off-by: Aaron Chong <[email protected]>
@aaronchongth aaronchongth mentioned this pull request Jun 19, 2024
Merged
aaronchongth added a commit that referenced this pull request Jun 19, 2024
@aaronchongth
Use same empty string default value as fleet adapter launches (#237)
75a83ea 
Signed-off-by: Aaron Chong <[email protected]>
(cherry picked from commit 6a27d7c)
Signed-off-by: Aaron Chong <[email protected]>
@aaronchongth aaronchongth mentioned this pull request Jun 19, 2024
Merged
xiyuoh pushed a commit that referenced this pull request Jun 25, 2024
@aaronchongth @xiyuoh
Use same empty string default value as fleet adapter launches (#237)
ee6dcb5 
Signed-off-by: Aaron Chong <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxgrey mxgrey mxgrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronchongth @mxgrey