-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for georeferenced coordinates. #133
Conversation
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
This commit does the following: * moves everything into a self contained plugin * allows the system to work with File > New/Open * redraw tiles if reference is changed Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
… into arjo/feat/georeference
I've reworked the implementation significantly for this iteration and significantly simplified the user experience. It is probably ready for another round of review. The gaps between tiles have been eliminated. There are several ways to use this feature.
You may download an existing world here and open it. You should be able to see the world in the screen like so (notice no more gaps): You should also be able to toggle visibility from the "view" checklist. To enable this I added an API that allows us to extend menus via the ECS like what was done in #163 Screencast.from.2023-08-23.10-35-10.webmYou may also view the reference from the tools menu and change the tile reference via the settings. Note: There is a hard-coded tile limit setting the code (this is to prevent the cache size from exploding and us from hammering the OSM server). We should make this configurable in a future PR.
We can use the example world. Open the You may also use the Inspect Anchor tool to move anchors to desired latitudes and longitudes. We don't yet support using an anchor as a reference (that'll be a follow up PR) and we don't support lat/lon in the inspect Lane dialog (Also should be a follow up dialog). As for the default world, I've not added its coordinates to this PR. |
Signed-off-by: Michael X. Grey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new feature is very awesome! I've left feedback on some minor details, but fundamentally these changes are excellent.
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tweaked the syntax here to make it a bit nicer: b7b452e
Thanks for this feature, this is awesome!
New feature implementation
Implemented feature
Adds support for visualizing OSM maps and using Geographic coordinates (Lat/Lon) instead of just (x, y) coordinates.
To use:
Go to
tools
->Georeference
->Set Reference...
. Enter latitude and longitude of reference. PressSet Reference
. You should see the maps loading.You may also
set reference via anchor
or move an anchor to a specified latitude/longitude usingMove To Lat/Lon
You can adjust the map resolution using the bottom slider.
To view an offset you can use the
Tools
->Georeference
->View Reference as UTM
.Known Issues
utm
crate becauseProj
's rust binding does not yet support WASMUTM
.