Add open empty site button on launch menu #143
Conversation
Signed-off-by: Audrow Nash <[email protected]>
| demo_office(), | ||
| ))); | ||
| if ui.button("New site").clicked() { | ||
| _load_workspace.send(LoadWorkspace::Data(WorkspaceData::Site(empty_site()))); |
There was a problem hiding this comment.
You can always add a new parameter mut _new_workspace: EventWriter<CreateWorkspace> here:
rmf_site/rmf_site_editor/src/main_menu.rs
Line 44 in 8d226c3
and then send on that channel. That would reduce the need for your default world code. We should also merge #131 in first.
There was a problem hiding this comment.
I gave it a quick spin and it seems slightly hairy because the CreateNewWorkspace event requires the AppState to be set otherwise it will return an error. Naively setting the AppState before sending the event also seems to not work, probably because the state update was not flushed before the event reader ran. Therefore unless we reorder systems to make sure the app state was correctly set and flushed before the event reader runs the CreateNewWorkspace approach will not work.
Still embedding another demo map is not ideal. I suspect if we set the state and made sure the CreateNewWorkspace events are processed in a separate stage it should work. Another idea could be to just use the site constructor that is used inside the CreateNewWorkspace event handler for this, and just dispatch a LoadSite event.
It's a bit hacky but we need to refactor states soon anyway when upgrading the bevy version so 🤷
@arjo129 is right and we should definitely merge that PR first.
I'll also open up a quick PR to fix CI now that let else support has been added to rustfmt to make it green again.
|
I'm going to close this because it sounds like there are better approaches. |
This adds a button that loads an empty site (which I added to the assets).
When debugging, I was finding myself wanting to work from an empty world so, I would load the demo world and then go File > New. Instead, I just added an empty world to be loaded from the menu. This might be nice for people to start new projects from.
Probably the more correct way to do this is to use
CreateNewWorkspace, which I didn't see how to plumb through.