Skip to content

Commit

Permalink
build: improve build process for arm64 (#155)
Browse files Browse the repository at this point in the history
* fix: makefile

* build: update makefile naming

* wip: temp CI reusable workflow redirect

* fix: change workflow to point to main
  • Loading branch information
apaletta3 authored Mar 25, 2024
1 parent 3d80f4e commit d632356
Showing 1 changed file with 5 additions and 12 deletions.
17 changes: 5 additions & 12 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,9 @@ extract_python_package_version := $(shell echo $(project_version) | sed 's/-/./'
dev_username := developer


ifeq ($(PLATFORM),amd64)
platform := x86_64
endif

ifeq ($(PLATFORM),arm64)
platform := aarch64
endif

platform ?= x86_64
$(info Platform value is $(platform))
# Handle multi-platform builds locally (CI sets these env vars, but need defaults here)
TARGETPLATFORM ?= linux/amd64
$(info Target platform is $(TARGETPLATFORM))


pull: ## Pull all images
Expand Down Expand Up @@ -226,7 +219,7 @@ build-packages-cpp-standalone: ## Build C++ packages (standalone)
@ echo "Building C++ packages..."

docker run \
--platform ${platform} \
--platform $(TARGETPLATFORM) \
--rm \
--volume="$(CURDIR):/app:delegated" \
--volume="/app/build" \
Expand All @@ -250,7 +243,7 @@ build-packages-python-standalone: ## Build Python packages (standalone)
@ echo "Building Python packages..."

docker run \
--platform ${platform} \
--platform $(TARGETPLATFORM) \
--rm \
--volume="$(CURDIR):/app:delegated" \
--volume="/app/build" \
Expand Down

0 comments on commit d632356

Please sign in to comment.